The Wayback Machine - https://web.archive.org/web/20201223155121/https://github.com/tinygo-org/tinygo/pull/1235
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: remove optimization level 0 #1235

Merged
merged 1 commit into from Jul 16, 2020
Merged

builder: remove optimization level 0 #1235

merged 1 commit into from Jul 16, 2020

Conversation

@niaow
Copy link
Member

@niaow niaow commented Jul 11, 2020

Currently, turning optimizations off causes compile failures.
We rely on the optimizer removing some dead symbols.
Avoid providing an option that does not work right now.
In the future once everything has been fixed we can re-enable this.

Currently, turning optimizations off causes compile failures.
We rely on the optimizer removing some dead symbols.
Avoid providing an option that does not work right now.
In the future once everything has been fixed we can re-enable this.
@aykevl aykevl merged commit ae5b297 into tinygo-org:dev Jul 16, 2020
8 checks passed
8 checks passed
ci/circleci: assert-test-linux Your tests passed on CircleCI!
Details
ci/circleci: build-linux Your tests passed on CircleCI!
Details
ci/circleci: build-macos Your tests passed on CircleCI!
Details
ci/circleci: test-llvm10-go112 Your tests passed on CircleCI!
Details
ci/circleci: test-llvm10-go113 Your tests passed on CircleCI!
Details
ci/circleci: test-llvm10-go114 Your tests passed on CircleCI!
Details
ci/circleci: test-llvm9-go111 Your tests passed on CircleCI!
Details
tinygo-CI #20200711.13 succeeded
Details
@aykevl
Copy link
Member

@aykevl aykevl commented Jul 16, 2020

Seems reasonable, so merged.

I looked into fixing this before, but never figured out how to fix it. Some TinyGo passes introduce dead globals that should be removed but aren't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.