The Wayback Machine - https://web.archive.org/web/20200713192051/https://github.com/HeroTransitions/Hero/issues/525
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Detail navigation controller disabled when searchController is active on parent #525

Open
macfurin opened this issue Sep 6, 2018 · 1 comment

Comments

@macfurin
Copy link

@macfurin macfurin commented Sep 6, 2018

On a tableview controller, when a search controller (iOS 11+) is active (editing), I select a detail row and push a detail view controller, the back button item interaction works as expected and pop detail view controller.
With search controller always active or not, if I select again a detail row, then the back button (or any other button in navigation bar) on detail view controller is disabled : impossible to pop view controller !

When I disable Hero on master's navigation controller, then the problem is gone.

I also observe a strange animation of search bar when popping detail view controller with search controller active and Hero enabled (as mentioned in issue #387 )

I think there is a bug with snapshot on view controller with search bar active.

@arkilite
Copy link

@arkilite arkilite commented Sep 24, 2018

Same issue here; when I select again a detail row this warning appear in console: "changing items while animating can result in a corrupted navigation bar".
If you set dimsBackgroundDuringPresentation = true on UISearchController the problem is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.