The Wayback Machine - https://web.archive.org/web/20200718021246/https://github.com/SheetJS/sheetjs/issues/1621
Skip to content

/ sheetjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading Excel HTML files will misalign cells in some cases #1621

Open
KurtMar opened this issue Sep 12, 2019 · 1 comment · May be fixed by #1684
Open

Reading Excel HTML files will misalign cells in some cases #1621

KurtMar opened this issue Sep 12, 2019 · 1 comment · May be fixed by #1684
Labels
good first issue

Comments

@KurtMar
Copy link

@KurtMar KurtMar commented Sep 12, 2019

I noticed a bug in the html_to_sheet function. When reading cells that are empty, the cell index is correctly incremented, but if the cell has HTML tags and is observed to be empty after stripping the tags, the cell index is not incremented. This results in misalignment of the subsequent cells:

https://github.com/SheetJS/js-xlsx/blob/e3c5eac99c3b2be6929adfca455c1be87fab792b/xlsx.js#L18956-L18960
@SheetJSDev
Copy link
Member

@SheetJSDev SheetJSDev commented Sep 12, 2019

Thanks for reporting @KurtMar , indeed that line should be the same as the previous check. We'd accept a PR, please change the line in bits/79_html.js

Simple repro:

<table>
	<tr>
		<td>abc</td>
		<td><b> </b></td>
		<td>def</td>
	</tr>
<table>
KurtMar added a commit to KurtMar/sheetjs that referenced this issue Nov 20, 2019
@KurtMar
Fix for Issue: SheetJS#1621 - Reading Excel HTML files will misalign …
7744c4a 
…cells in some cases
@KurtMar KurtMar linked a pull request that will close this issue Nov 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix for Issue: #1621 - Reading Excel HTML files will misalign cells in some cases
2 participants
@SheetJSDev @KurtMar
You can’t perform that action at this time.