The Wayback Machine - https://web.archive.org/web/20210210084943/https://github.com/github/gitignore/pull/3451
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JetBrains note for PyCharm to Python.gitignore #3451

Open
wants to merge 1 commit into
base: master
from

Conversation

@BrianMSheldon
Copy link

@BrianMSheldon BrianMSheldon commented Jun 24, 2020

Reasons for making this change:

First and foremost I think that requiring such a complicated gitignore for JetBrains IDEs is a failure on JetBrains part in structuring their project setting. I also feel that it should be included in the Python.gitignore due to its popularity and due to the frequency of requests. A quick search for PyCharm PRs shows 81 closed PRs requesting it be added and if searching for .idea you can see many more have been requested. However I understand the maintenance burden in including it when a user can manually merge the two files themselves so I understand why the maintainers have opted to maintain it seperately.

The main problem I see is that with many people adding the Python.gitignore at project creation through the Github UI and the JetBrains.gitignore being in the Global folder makes it less discoverable than it should be.

This PR adds a comment to the Python.gitignore directing users to the global JetBrains.gitignore. I believe this solves the issue in a way that is acceptable for the maintainers since comment-only sections already exist for pyenv and pipenv.

Links to documentation supporting these rule changes:

Closed PyCharm and .idea PRs
pyenv comment
pipenv comment

First and foremost I think that requiring such a complicated gitignore for JetBrains IDEs is a failure on JetBrains part in structuring their project setting.  I also feel that it should be included in the `Python.gitignore` due to its popularity and due to the frequency of requests.  A quick search for `PyCharm` PRs shows 81 closed PRs requesting it be added and if searching for `.idea` you can see many more have been requested.  However I understand the maintenance burden in including it when a user can manually merge the two files themselves so I understand why the maintainers have opted to maintain it seperately.  

The main problem I see is that with many people adding the `Python.gitignore` at project creation through the Github UI and the `JetBrains.gitignore` being in the Global folder and makes it less discoverable than it should be.  

This PR adds a comment for people adding the `Python.gitignore` directing them to the global `JetBrains.gitignore` which should solve this issue in a way that is acceptable for the maintainers, since comment-only sections already exist for `pyenv` and `pipenv`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants