The Wayback Machine - https://web.archive.org/web/20200914053446/https://github.com/github/octodns/pull/101
Skip to content

/ octodns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring to support geo cname #101

Open
wants to merge 6 commits into
base: master
from
Open

[WIP] Refactoring to support geo cname #101

wants to merge 6 commits into from
+279 −90

Conversation

@ross
Copy link
Contributor

ross commented Aug 21, 2017

  • GeoMixin -> GeoValuesMixin
  • GeoValueMixin added
  • GeoValue -> GeoBase, GeoValue, and GeoValues
  • related tests & cleanup
@ross
First pass through at refactoring to support geo cname
Verified
This commit was signed with a verified signature.
ross Ross McFarland
GPG key ID: 61C10C4FC8FE4A89 Learn about signing commits
Loading status checks…
e1e87a1 
- GeoMixin -> GeoValuesMixin
- GeoValueMixin added
- GeoValue -> GeoBase, GeoValue, and GeoValues
- related tests & cleanup
@ross ross self-assigned this Aug 21, 2017
@ross
Merge branch 'master' into geo-cname
Loading status checks…
62f4c5d
@ross ross mentioned this pull request Aug 21, 2017
Closed
ross added 4 commits Aug 28, 2017
@ross
Merge remote-tracking branch 'origin/master' into geo-cname
Verified
This commit was signed with a verified signature.
ross Ross McFarland
GPG key ID: 61C10C4FC8FE4A89 Learn about signing commits
e60acef
@ross
Merge branch 'geo-cname' of github.com:github/octodns into geo-cname
Verified
This commit was signed with a verified signature.
ross Ross McFarland
GPG key ID: 61C10C4FC8FE4A89 Learn about signing commits
Loading status checks…
7c98bb9
@ross
quick pass of hacks at getting cname going
Verified
This commit was signed with a verified signature.
ross Ross McFarland
GPG key ID: 61C10C4FC8FE4A89 Learn about signing commits
Loading status checks…
4ab357f
@ross
Lint compliance
Verified
This commit was signed with a verified signature.
ross Ross McFarland
GPG key ID: 61C10C4FC8FE4A89 Learn about signing commits
Loading status checks…
4ecd2cd
@ashishprajapati
Copy link

ashishprajapati commented Mar 18, 2019

@ross :) Are we now supporting geo cnames for Dyn and Route53 ? Or this is something, still remaining to be finished. I just reached at my PR that was raised long time ago #100 and you also worked around same thing so I stopped it in between.
Thanks
@ross
Copy link
Contributor Author

ross commented Mar 18, 2019

@ross :) Are we now supporting geo cnames for Dyn and Route53 ?

There's "alpha" support for DynProvider currently in master (dark shipped for now) as dynamic records. They work quite differently and should be more powerful in general, including support for CNAMEs. I'm planning to start working on Route53Provider support before too long. Once that lands I'll call it "beta" and go from there 😁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ross ross

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ross @ashishprajapati
You can’t perform that action at this time.