The Wayback Machine - https://web.archive.org/web/20201012024111/https://github.com/huginn/huginn/pull/2795
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jira to include changelog, and update docs #2795

Open
wants to merge 1 commit into
base: master
from

Conversation

@spdustin
Copy link
Contributor

@spdustin spdustin commented May 19, 2020

This commit updates documentation with link to get API Token (used in lieu of passwords now for Jira Cloud), and adds full Jira Issue changelog details in the created events.

This commit updates documentation with link to get API Token (used in lieu of passwords now for Jira Cloud), and adds full Jira Issue changelog details in the created events.
- `timeout` is an optional parameter that specifies how long the request processing may take in minutes.
- The issue's `changelog` is now returned with this Agent.

This comment has been minimized.

@dsander

dsander May 22, 2020
Collaborator

Interesting idea to use the Agent description as a changelog. Not really sure how I feel about it, at first I didn't like it, but after thinking about it it kind of makes sense.
If we keep it, I think I would prefer it at the bottom of the description and add a date.

@@ -84,7 +85,7 @@ def check

private
def request_url(jql, start_at)
"#{interpolated[:jira_url]}/rest/api/2/search?jql=#{CGI::escape(jql)}&fields=*all&startAt=#{start_at}"
"#{interpolated[:jira_url]}/rest/api/2/search?jql=#{CGI::escape(jql)}&expand=changelog&fields=*all&startAt=#{start_at}"

This comment has been minimized.

@dsander

dsander May 22, 2020
Collaborator

Does the changelog change the shape of the parts of the Event that were already present before this change?

The tests probably need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.