Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove dependence on the HexColors pod. #161
Conversation
|
I guess that would be something for @mRs-, who is the developer of HexColors |
|
Why should we remove the pod? The Pod itself is just working fine. In all of my projects that are working with HexColors i would have doubled my code base… |
|
I agree with @mRs- here. It's an advantage to have a dependency to not pull the same code multiple times if it's already in the project |
|
We should remove it because it is not required to achieve the goal of the project. The user of our library could be using a number of other libraries that do the same thing (quick count on cocoapods 7). At present we force them to also include HexColors. You raise a good point though Marcus. We can simplify further by not using hex codes to define our colours and removing the category I added. If the user want to use hex codes they should decide which library they want to use. |
|
What alternative to Hex codes would you use in our JSON configuration? |
|
Sorry, an oversight, we need hex codes after all. However we should not tightly couple the project to another. |
|
|
I have removed this pod since it can be replaced by just a few lines of code.
Does anyone have objections?