Print param groups after initialization #291

ottonemo · 2018-07-19T11:06:33Z

We should be verbose about the param groups that are added after initialization (since we support wildcards and it may be intransparent which param groups are created from that).

For example:

>>> net = Net(optimizer__param_groups=[('dense*', {'lr': 0.03})])
Initializing module!
Setting param group {'lr': 0.03} for dense0.weight, dense0.bias, dense1.weight, dense1.bias.

thomasjpfan · 2018-08-09T22:30:34Z

I can see two ways to implement this feature:

Use a callback with a sink parameter that prints the param group during on_train_begin.
Print the param group in NeutralNet.initialize_optimizer when verbose is truthy.

What do you think?

benjamin-work · 2018-08-16T12:39:34Z

@ottonemo do you have an opinion on that?

ottonemo · 2018-12-12T13:49:30Z

Since the introduction of virtual parameters we have dedicated setter methods for these parameters. This means that we have two places where this message may be relevant:

during initialization from Net kwargs
when setting using set_params(optimizer__0__lr=0.03)
There should probably a utility function to print this message (of course we could think about a special callback that gets triggered when parameters are set but I don't think this is particularly helpful).

ottonemo added enhancement good first issue labels Jul 19, 2018

Aug	SEP	Oct
	11
2019	2020	2021

skorch-dev / skorch

Print param groups after initialization #291

Print param groups after initialization #291

ottonemo commented Jul 19, 2018 •

edited

thomasjpfan commented Aug 9, 2018

benjamin-work commented Aug 16, 2018

ottonemo commented Dec 12, 2018

skorch-dev / skorch

Join GitHub today

Print param groups after initialization #291

Print param groups after initialization #291

Comments

ottonemo commented Jul 19, 2018 • edited

thomasjpfan commented Aug 9, 2018

benjamin-work commented Aug 16, 2018

ottonemo commented Dec 12, 2018

ottonemo commented Jul 19, 2018 •

edited