The Wayback Machine - https://web.archive.org/web/20200914160822/https://github.com/gigya/microdot/pull/257
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot net standard #257

Open
wants to merge 194 commits into
base: develop
from
Open

Dot net standard #257

wants to merge 194 commits into from

Conversation

@EranOfer
Copy link
Contributor

EranOfer commented Oct 16, 2019

No description provided.

Alexander Chirlin and others added 30 commits May 16, 2019
fix seriveProxy provider whwn sorce is local
@@ -321,8 +321,8 @@ private async Task SetResponse(HttpListenerContext context, string serviceName,

public void Dispose()
{
_consulListener.Close();
((IDisposable)_consulListener)?.Dispose();
//_consulListener.Close();

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

Should understand the issue.
dispose should not throw an exception or cause other side effects

@@ -2,7 +2,7 @@
<configuration>
<Discovery>
<Services>
<CalculatorService Source="Local" />
<CalculatorService Source="Config" Hosts="127.0.0.1" DefaultPort="12323"/>

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

Revert

<TargetFramework>netstandard2.0</TargetFramework>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageVersion>7.0.3-beta</PackageVersion>

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

The package version should be 6.
The build server Identify branch is not master and therefor create a beta version.

Also, we want one nuspec file that controls the version. ( microdot come as a full package)

@@ -69,13 +69,11 @@ public CurrentApplicationInfo(string name, string instanceName = null, Version i
if (name == null)
throw new ArgumentNullException(nameof(name));

OsUser = WindowsIdentity.GetCurrent().Name;
OsUser = "N/A";

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

can you find a way in Linux to get the Current user?

// ReSharper disable once PossibleNullReferenceException
IsRunningAsWindowsService = Environment.OSVersion.Platform == PlatformID.Win32NT &&
WindowsIdentity.GetCurrent().Name == @"NT AUTHORITY\SYSTEM";
IsRunningAsWindowsService = false;

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

@daniel-lamberger can we remove WindowsService support?

This comment has been minimized.

@aikixd

aikixd Jan 9, 2020

Collaborator

Environment.UserName

@@ -296,6 +297,10 @@ private async Task HandleRequest(HttpListenerContext context)
}
}
}
finally
{

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

we need more investigation to understand doker in Linux

@@ -71,7 +71,7 @@ public async Task<ConfigItemsCollection> GetConfiguration()
.Select(match => new
{
Placehodler = "%" + match.Groups[1].Value + "%",
Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value)
Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value.ToUpper())

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor
  1. Can you please move the ToUpper to the where.
  2. add readme that describes our environment variable format ( Upper case key, lower case value )
@@ -65,7 +65,28 @@ public ConfigurationFilesWatcher(IConfigurationLocationsParser configurationLoca

private void CreateRootWatcher()
{

var usePolling = Environment.GetEnvironmentVariable("GIGYA_CONFIG_USE_POLLING");

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

@daniel-lamberger what do you think about polling instead of Watcher.
(due to docker on windows have no support in file system Watcher)

@@ -97,7 +97,7 @@ public void OrleansSerialization_CustomerFacingException_IsEquivalent()
/// [DONE] #ORLEANS20 - I don't now why, but round/trip for HttpRequestException is loosing stack trace...
/// https://github.com/dotnet/orleans/issues/5876
/// </summary>
[Test]
[Test, Ignore("Waiting for issue to be fixed by Orleans")]

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

let's try to find other solution for that

@@ -356,7 +354,7 @@ public async Task RequestContextOverrideShouldFailOnFirstAttempt()

//Disable TracingContext.SetRequestID("1");

CallContext.FreeNamedDataSlot("#ORL_RC");
TracingContext.ClearContext();// CallContext.FreeNamedDataSlot("#ORL_RC");

This comment has been minimized.

@EranOfer

EranOfer Oct 16, 2019

Author Contributor

remove zombi code :P

@aikixd aikixd force-pushed the develop branch from 68ef31f to 49b82a0 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.