Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDot net standard #257
Dot net standard #257
Conversation
…gacy, Logging.Legacy
…ix silo
…gya/microdot into us/95878.infra.orleans.2_20.5
fix seriveProxy provider whwn sorce is local
@@ -321,8 +321,8 @@ private async Task SetResponse(HttpListenerContext context, string serviceName, | |||
|
|||
public void Dispose() | |||
{ | |||
_consulListener.Close(); | |||
((IDisposable)_consulListener)?.Dispose(); | |||
//_consulListener.Close(); |
This comment has been minimized.
This comment has been minimized.
EranOfer
Oct 16, 2019
Author
Contributor
Should understand the issue.
dispose should not throw an exception or cause other side effects
@@ -2,7 +2,7 @@ | |||
<configuration> | |||
<Discovery> | |||
<Services> | |||
<CalculatorService Source="Local" /> | |||
<CalculatorService Source="Config" Hosts="127.0.0.1" DefaultPort="12323"/> |
This comment has been minimized.
This comment has been minimized.
<TargetFramework>netstandard2.0</TargetFramework> | ||
<GenerateAssemblyInfo>false</GenerateAssemblyInfo> | ||
<GeneratePackageOnBuild>true</GeneratePackageOnBuild> | ||
<PackageVersion>7.0.3-beta</PackageVersion> |
This comment has been minimized.
This comment has been minimized.
EranOfer
Oct 16, 2019
Author
Contributor
The package version should be 6.
The build server Identify branch is not master and therefor create a beta version.
Also, we want one nuspec file that controls the version. ( microdot come as a full package)
@@ -69,13 +69,11 @@ public CurrentApplicationInfo(string name, string instanceName = null, Version i | |||
if (name == null) | |||
throw new ArgumentNullException(nameof(name)); | |||
|
|||
OsUser = WindowsIdentity.GetCurrent().Name; | |||
OsUser = "N/A"; |
This comment has been minimized.
This comment has been minimized.
// ReSharper disable once PossibleNullReferenceException | ||
IsRunningAsWindowsService = Environment.OSVersion.Platform == PlatformID.Win32NT && | ||
WindowsIdentity.GetCurrent().Name == @"NT AUTHORITY\SYSTEM"; | ||
IsRunningAsWindowsService = false; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@@ -296,6 +297,10 @@ private async Task HandleRequest(HttpListenerContext context) | |||
} | |||
} | |||
} | |||
finally | |||
{ |
This comment has been minimized.
This comment has been minimized.
@@ -71,7 +71,7 @@ public async Task<ConfigItemsCollection> GetConfiguration() | |||
.Select(match => new | |||
{ | |||
Placehodler = "%" + match.Groups[1].Value + "%", | |||
Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value) | |||
Value = _environmentVariableProvider.GetEnvironmentVariable(match.Groups[1].Value.ToUpper()) |
This comment has been minimized.
This comment has been minimized.
EranOfer
Oct 16, 2019
Author
Contributor
- Can you please move the ToUpper to the where.
- add readme that describes our environment variable format ( Upper case key, lower case value )
@@ -65,7 +65,28 @@ public ConfigurationFilesWatcher(IConfigurationLocationsParser configurationLoca | |||
|
|||
private void CreateRootWatcher() | |||
{ | |||
|
|||
var usePolling = Environment.GetEnvironmentVariable("GIGYA_CONFIG_USE_POLLING"); |
This comment has been minimized.
This comment has been minimized.
EranOfer
Oct 16, 2019
Author
Contributor
@daniel-lamberger what do you think about polling instead of Watcher.
(due to docker on windows have no support in file system Watcher)
@@ -97,7 +97,7 @@ public void OrleansSerialization_CustomerFacingException_IsEquivalent() | |||
/// [DONE] #ORLEANS20 - I don't now why, but round/trip for HttpRequestException is loosing stack trace... | |||
/// https://github.com/dotnet/orleans/issues/5876 | |||
/// </summary> | |||
[Test] | |||
[Test, Ignore("Waiting for issue to be fixed by Orleans")] |
This comment has been minimized.
This comment has been minimized.
@@ -356,7 +354,7 @@ public async Task RequestContextOverrideShouldFailOnFirstAttempt() | |||
|
|||
//Disable TracingContext.SetRequestID("1"); | |||
|
|||
CallContext.FreeNamedDataSlot("#ORL_RC"); | |||
TracingContext.ClearContext();// CallContext.FreeNamedDataSlot("#ORL_RC"); |
EranOfer commentedOct 16, 2019
No description provided.