The Wayback Machine - https://web.archive.org/web/20201013012140/https://github.com/kubernetes/minikube/issues/9323
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate logging implementation from google/glog to kubernetes/klog #9323

Open
tstromberg opened this issue Sep 25, 2020 · 1 comment · May be fixed by #9355
Open

Migrate logging implementation from google/glog to kubernetes/klog #9323

tstromberg opened this issue Sep 25, 2020 · 1 comment · May be fixed by #9355

Comments

@tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Sep 25, 2020

This is required for #9156

Switching from https://github.com/kubernetes/klog to https://github.com/google/glog should be easy, as klog is a newer fork of glog. klog supports the ability to specify log destinations, which is why it is important for #9156

This should be achievable mostly a search & replace of glog to klog, but initialization is slightly different. See this PR I proposed & abandoned last year: #5318 - though that was with klog v1, and now klog v2 is available. Here's an example of klog usage:

https://github.com/kubernetes/klog/blob/master/examples/log_file/usage_log_file.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.