Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
FileWriterGenerator temp name fix #412
Closed
Conversation
tempname will not work on location that includes proxy php class file name, as passed in location. This is generated in generate() as from the $this->fileLocator->getProxyFileName($className). In reality we need the dirname base path of the desired location to pass into tempname.
|
@mainegreen this requires a test case demonstrating how the current approach is incorrect/fails, and that the patch fixes that. |
|
I just noticed this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tempname will not work on location that includes proxy php class file name, as passed in location. This is generated in generate() as from the $this->fileLocator->getProxyFileName($className). In reality we need the dirname base path of the desired location to pass into tempname.