Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate to TypeScript #551
Comments
I'd like to start working on this, I have some experience with Ts, can you tell me which module is up for grabs? |
@yashshah1 You are welcome to contribute, please pick any module or portion for conversion and mention it here, so I can mark it in-progress (to avoid any duplication effort). |
I'd like to work on this too, any recommendations on where to start? |
@nabeelvalley here is the short guide, super simple to start. Please pick any module or portion for conversion and mention it here, so I can mark it in-progress (to avoid any duplication effort). Here you can find a guide on how to contribute. |
@mubaidr I'm working from the The tests seem to be failing when I convert the file to JS because it looks like Jest is running against the TS files instead of the compiled JS - has the TS Compile been configured? Looks like the tests are also currently failing:
It appears that the The data returned looks exactly the same, it's just that the object types are different so the deep equality is failing: Example for one of the tests below:
|
Yes, you can update test to expect In the mean-time some tests might still fail, because they have not yet been updated recently. You can can continue working and make sure build process is successful and conversion does not cause increase in no. of failed tests. |
Hi! I want to help. If I convert one file, do I need to convert related files too or something? Or just a single file? |
You don't need to updated all the related files, just go file by file and make sure build is successful. |
Utilities is taken, isnt it? |
Activation functions seem like a good place to start, may I work on it? |
Hi @HarshKhandeparkar, I haven't had a chance to work on this you're welcome to take utilities if you want, just note that needs to be updated above |
Np @nabeelvalley. I think I'll work on activation functions :) |
@nabeelvalley I think I managed to fix the jest error you were facing in #582. You may copy paste my changes to |
estimator/ has a single file. Looks like a nice |
I think I'll snipe some of the utilities next, if you don't mind @nabeelvalley. |
You would have probably started in alphabetical order(I am assuming), so I am going to start from the bottom. |
Going to snipe utilities/values* tonight :) |
Huzzah! |
Build systems seems to be broken, I am looking into this issue. |
Can I continue or should I wait? |
You should continue your contributions! I will try to fix it asap. |
Can someone pickup src/recurrent/matrix/copy.js? |
It's already ts ¯\_(ツ)_/¯ |
Ah, I was looking at the export, not extension. I'll take care of converting to named export. |
Hello! I want to contribute, can I convert tests/utilities/layer-size.js to typescript? |
@LuanSilveiraSouza sure, go ahead! |
I'd like to start working on this, can you tell me which module i can start with? |
@rohya8 Please select any file(s) from |
I'll take a stab at https://github.com/BrainJS/brain.js/blob/master/__tests__/recurrent/unit.js |
convert __tests__/recurrent/unit.js => ts #551
I'll contribute to |
@dhairyagada You can pick other files please. |
@mubaidr Can I know which one's are remaining? |
All other |
@mubaidr Thanks! I'll start with it |
@mubaidr Has |
I have a locally converted tests/utilities/data-formatter.js |
Hello again! I will convert |
Hey, I would like to convert /tests/neural-network/to-function.js to ts |
@dhairyagada No, its in progress. But I don't think you would need it. |
@mubaidr |
We plan to gradually migrate brain.js to TypeScript, code base is pretty large, so we would love your help!💪
How to contribute?
Here you can find a guide on how to contribute.
Want to convert something, let us know in the comment and go ahead!😎
To avoid duplicate work please comment on which part you want to work on (as long as nobody else is working on it) so we can mark it as taken.
Reach out to us!
Feel free to reach if you have questions or need help getting started. You can leave comments here or you can tag me in your PR if you need any help or you're not sure about something!
You can also get in touch on our
&
.
Happy Coding!🤟
UPDATE:
Wohoooo!!!🎉
All files inside😊
src
directory are migrated to typescript. (Except few ones which are already taken up and being worked on), though we are still looking on improvements to types in these files and removingany
types from the source. You are welcome to contribute.__tests__
directory has still some files left that needs migration to typescript, so feel free to pick em up!