Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPlots of benchmarks without params have a double dash (--) in the name #1183
Comments
Hi, @AndreyAkinshin. Is this issue still actual? I can't reproduce it on Windows 10, R-3.6.1. |
@marcnet80 yes, the issue is still actual. I guess, the problem is in this line: https://github.com/dotnet/BenchmarkDotNet/blob/v0.11.5/src/BenchmarkDotNet/Templates/BuildPlots.R#L112 |
@AndreyAkinshin, thank you for pointing, values for params are coming from generated ..-measurements.csv in this line of code: |
@marcnet80 it's better to fix it in the R-script. |
Ok. Pull-request added. |
remove "Default"
fix assignment operations
replace assignments operator
* Plots with a double dash (--) in the names (#1183) #1183 * Plots with a double dash (--) in the names (#1183) remove "Default" * Plots with a double dash (--) in the names (#1183) fix assignment operations * Plots with a double dash (--) in the names (#1183) replace assignments operator * Plots with a double dash (--) in the names (#1183) #1212
For each Job, it adds plots about density, cumulative mean, and so on. But two files are named

BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-Time50--density.png
andBenchmarkDotNet.Artifacts/results/MyBench.Sleeps-Time50--facetDensity.png
, with the--
instead of single. Like some iteration variable is empty (since later there are names with-Default-
I've noticed that this last error only happens without parameters. When there are parameters involved, there are no
--
files.