PR o'clock

Description

1. Add ingress rule to workers and cluster security groups to allow Fargate pods to communicate with EC2 nodes
2. Allow EKS Fargate profiles to be created via input eks_fargate_profiles = [...]. This also creates an IAM role for pod execution and extends the aws-auth ConfigMap.

Checklist

• CI tests are passing
• README.md has been updated aft

https://github.com/terraform-aws-modules/terraform-aws-atlantis/blob/508eb0c3bb99a84dfe9fdbe57f1989be711f4197/main.tf#L235

More details on:
https://docs.docker.com/config/containers/logging/awslogs/#awslogs-datetime-format
https://docs.docker.com/config/containers/logging/awslogs/#awslogs-multiline-pattern

container definition docs: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html#advanced_container_definition_params

• hostname
• disableNetworking
• dockerSecurityOptions
• interactive
• pseudoTerminal

There will be more in the future. At least any missing keys can be added using the var.container_definition override.

Since you require Terraform 0.12.x, I think it's better to use the templatefile function instead.

...and you've got 100 stars 🎉

Have a question? Please checkout our Slack Community in the #geodesic channel or visit our Slack Archive.

Describe the Feature

Currently the module does not allow the modification of the order of the label. this feature

Describe the Bug

Whatever is in security_groups seems to be ignored

Expected Behavior

Security groups specified in security_groups should be applied

Steps to Reproduce

security_groups = [aws_security_group.my_group1.id, aws_security_group.my_group2.id]

Screenshots

Output of terraform plan:

 ~ vpc_options {
            availability_zones = [