SolrNet using plain SolrConnection when AutoSolrConnection injected with Windsor #459

Seebiscuit · 2018-12-06T21:03:32Z

In our project we handle SolrNet operations through a repository which we instantiate like this:

//Our project deploys one "case" per client and each client has their own Solr core
//which we name based on their "caseId"
public SolrSearchRepository(int caseId, string solrServer)
{
    var coreName = "core_" + caseId;

    this.container = new WindsorContainer();
    this.container.Register(Component.For<ISolrConnection>()
                .ImplementedBy<AutoSolrConnection>()
                .DependsOn(Parameter.ForKey("serverUrl").Eq(solrServer)));

    this.facility = new SolrNetFacility(solrServer);
    this.facility.AddCore(coreName, typeof(SolrDocument), solrServer + "/" + caseId);

    this.container.AddFacility(this.facility);

    solrOperation = this.container.Resolve<ISolrOperations<SolrDocument>>(coreName);
}

Where ISolrConnection is implemented by the AutoSolrConnection class @gjunge recently contributed.

With this setup SolrNet is still using a GET request when sending queries.

I looked deeper into the matter and luckily I found this:

SolrNet/Castle.Facilities.SolrNetIntegration/SolrNetFacility.cs

Line 193 in 5793e6c

    
           public void AddCore(Type documentType, string coreUrl, bool postConnection = false)

where I noticed that AddCore takes a postConnection parameter. Supplying a true value for the postConnection param toggled a POST request for queries.

I was thus able to reduce my core setup to:

//Our project deploys one "case" per client and each client has their own Solr core
//which we name based on their "caseId"
public SolrSearchRepository(int caseId, string solrServer)
{
    var coreName = "core_" + caseId;

    this.container = new WindsorContainer();

    this.facility = new SolrNetFacility(solrServer);
    this.facility.AddCore(coreName, typeof(SolrDocument), solrServer + "/" + caseId);

    this.container.AddFacility(this.facility);

    solrOperation = this.container.Resolve<ISolrOperations<SolrDocument>>(coreName);
}

I have the following questions and comments:

Since I'm using the SolrnetFacility does that override any components I register on the WindsorContainer? If yes, how could I use AutoSolrConnection?
There is no documentation on how to implement SolrPostConnection on a multi-core setup.
There is no documentation on AutoSolrcConnection

For comments 2) and 3) I'd be happy to push a PR if there's interest.

xmorera · 2018-12-06T21:25:29Z

Regarding documentation, please contribute as much as possible. For the other question, perhaps @gjunge may have an answer.

gjunge · 2018-12-12T12:36:34Z

AutosolrConnection has not been added to the other DI containers. I'm not really familiar with Windsor, so I wouldn't be able to tell you what takes presedence. I do think it might be good to change the implementation, and by default use the AutoSolrConnection.

Sep	OCT	Nov
	29
2019	2020	2021

SolrNet / SolrNet

SolrNet using plain SolrConnection when AutoSolrConnection injected with Windsor #459

SolrNet using plain SolrConnection when AutoSolrConnection injected with Windsor #459

Seebiscuit commented Dec 6, 2018 •

edited

xmorera commented Dec 6, 2018

gjunge commented Dec 12, 2018

SolrNet / SolrNet

Join GitHub today

SolrNet using plain SolrConnection when AutoSolrConnection injected with Windsor #459

SolrNet using plain SolrConnection when AutoSolrConnection injected with Windsor #459

Comments

Seebiscuit commented Dec 6, 2018 • edited

xmorera commented Dec 6, 2018

gjunge commented Dec 12, 2018

Essential cookies

Always active

Analytics cookies

Seebiscuit commented Dec 6, 2018 •

edited