Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Feature/agency cache database subscription #12594
Merged
Conversation
…ture/agency-cache-database-subscription
…ture/agency-cache-database-subscription
…ture/agency-cache-database-subscription
…ture/agency-cache-database-subscription
…ture/agency-cache-database-subscription
|
Some comments. I basically looked at AgencyCache and a few smaller files which seemed ready. |
arangod/Cluster/AgencyCache.cpp
Outdated
| #include "GeneralServer/RestHandler.h" | ||
| #include "Scheduler/Scheduler.h" | ||
| #include "Scheduler/SchedulerFeature.h" | ||
|
|
||
| using namespace arangodb; | ||
| using namespace arangodb::consensus; | ||
|
|
||
| namespace std { |
neunhoef
Sep 2, 2020
Contributor
Should be unnecessary by std::shared_lock
Should be unnecessary by std::shared_lock
arangod/Cluster/AgencyCache.cpp
Outdated
| // Fill existing Builder from readDB, mainly /Plan /Current | ||
| index_t AgencyCache::get(VPackBuilder& result, std::string const& path) const { | ||
| result.clear(); | ||
| std::lock_guard g(_storeLock); | ||
| std::shared_lock_guard g(_storeLock); |
neunhoef
Sep 2, 2020
Contributor
Just use std::shared_lock
Just use std::shared_lock
…ture/agency-cache-database-subscription
…ture/agency-cache-database-subscription
…github.com/arangodb/arangodb into feature/agency-cache-database-subscription
…-database-subscription
…-database-subscription
|
LGTM. After the latest changes. However, need to address the TODOs in |
…ture/agency-cache-database-subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Scope & Purpose
(Please describe the changes in this PR for reviewers)
Backports:
Related Information
(Please reference tickets / specification etc)
Testing & Verification
(Please pick either of the following options)
Additionally:
(Include link to Jenkins run etc)
Documentation
External contributors / CLA Note
Please note that for legal reasons we require you to sign the Contributor Agreement
before we can accept your pull requests.