Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upNo commitSha on /version when running MeiliSearch from Docker #712
Comments
We spent some time investigating this with @eskombro yesterday, and could not come up with a reasonable solution. The trick would be to copy the |
Yes, the problem is due to the Using the github release binary inside of the docker container will probably be harder to do because both, the docker and the binaries are currently built at the same time, and therefore the docker image will not be able to access the binaries. I think with Github Action we could specify that a certain build must run after another one, we should look into that. If we do so we will have to create two GA pipelines, one for the common PRs and one for the releases. |
that seems like a reasonable solution Also build time for the container is up to 15min (we checked yesterday with @eskombro), it may not be desirable when you only want to run the container right away |
When running MeiliSearch from Docker, the route
/version
returns acomitSha
value asUNKNOWN
how to reproduce
docker run -it -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true
curl http://localhost:7700/version
RESPONSE: