The Wayback Machine - https://web.archive.org/web/20201109182213/https://github.com/ARMmbed/mbedtls/pull/3341
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing link to changelog howto #3341

Merged
merged 1 commit into from May 27, 2020

Conversation

@paul-elliott-arm
Copy link
Contributor

@paul-elliott-arm paul-elliott-arm commented May 21, 2020

Description

Fix the link from 'adding a changelog' in the Contributing document so that it points to the readme on creating an in progress changelog, rather than the changelog itself.

Status

READY

Backports

2.7
2.16

@paul-elliott-arm paul-elliott-arm self-assigned this May 21, 2020
@paul-elliott-arm paul-elliott-arm added this to To do in Current sprint via automation May 21, 2020
@yanesca
Copy link
Contributor

@yanesca yanesca commented May 21, 2020

It looks like you accidentally made your changes on the top of your other PR instead of development.

Make the contributing document link to how to create a changelog rather
than just linking to the Changelog itself.

Signed-off-by: Paul Elliott <[email protected]>
@paul-elliott-arm paul-elliott-arm force-pushed the paul-elliott-arm:fix-contributing branch from e50bda3 to 8c4fd40 May 21, 2020
@paul-elliott-arm
Copy link
Contributor Author

@paul-elliott-arm paul-elliott-arm commented May 21, 2020

Not entirely sure how that happened. Fixed.

@paul-elliott-arm paul-elliott-arm added this to To do in Mbed TLS PRs via automation May 21, 2020
@paul-elliott-arm paul-elliott-arm moved this from To do to 1 Approval in Mbed TLS PRs May 21, 2020
@paul-elliott-arm paul-elliott-arm moved this from To do to In progress in Current sprint May 21, 2020
Mbed TLS PRs automation moved this from 1 Approval to Approved May 22, 2020
@yanesca yanesca merged commit eee1f3b into ARMmbed:development May 27, 2020
12 checks passed
12 checks passed
DCO DCO
Details
PR-3341-head Mbed OS Testing All tests passed
Details
PR-3341-head Pre Test Checks OK
Details
PR-3341-head Result analysis OK
Details
PR-3341-head TLS Testing All tests passed
Details
PR-3341-merge Mbed OS Testing All tests passed
Details
PR-3341-merge Pre Test Checks OK
Details
PR-3341-merge Result analysis OK
Details
PR-3341-merge TLS Testing All tests passed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mbed TLS PRs automation moved this from Approved to Done May 27, 2020
Current sprint automation moved this from In progress to Done May 27, 2020
fengjixuchui added a commit to fengjixuchui/mbedtls that referenced this pull request May 27, 2020
Merge pull request ARMmbed#3341 from paul-elliott-arm/fix-contributing
@paul-elliott-arm paul-elliott-arm deleted the paul-elliott-arm:fix-contributing branch May 27, 2020
@danh-arm danh-arm removed this from Done in Current sprint May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mbed TLS PRs
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.