Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd fix for cmake control of CMAKE_BUILD_TYPE only if mbedtls is the root project #3790
Conversation
…root project Signed-off-by: Peter Toft <[email protected]>
peter-toft-greve
force-pushed the
peter-toft-greve:development
branch
from
370f853
to
fdf3379
|
Could you copy the description from the commit message into the description here? |
|
@paul-elliott-arm I have tried to update. Let me know if you suggest changes (or just update). |
|
BTW, if you want this PR, feel free to merge this in at the time it fits your work schedule and release cycle - or tell me so |
|
This looks good to me |
|
@paul-elliott-arm two questions;
|
|
|
@paul-elliott-arm others that can review? |
Its on the board in the right place, I am afraid we will need to wait for people to get the time to review it. Given its only a small patch, hopefully this won't take too long. |
|
This is typically how this is done in CMake for other projects. |
|
I am happy with this too, it makes sense from my understanding. |
|
The failure in pr-merge is a network glitch. Since the same job passed in earlier runs with the same content, this is as good as a pass. |
gilles-peskine-arm
merged commit 2da4292
into
ARMmbed:development
The current CMakeLists.txt has problems when making integration to other projects also running cmake.
The current code traverses the CMAKE_BUILD_TYPE to the mother project, which can be anything - thus clearly problematic.
Especially if the mother project has their own sanitizers setup the current code invalidates that from the mother project.
With the patch the code will let the project using mbedtls control the build types.
Solves: #3789
Signed-off-by: peter-toft-greve