COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20201109182236/https://github.com/ARMmbed/mbedtls/pull/3836

ARMmbed / mbedtls

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set iv size for ECB mode ciphers #3836

Merged

gilles-peskine-arm merged 1 commit into ARMmbed:development from bensze01:ecb_iv_fix

Nov 6, 2020

Contributor

bensze01 commented Oct 29, 2020 •

edited

This PR fixes the mbedtls_cipher_info_t structures in library/cipher_wrap.c that erroneously declare that block ciphers in ECB mode use IVs. (The AES ECB mode ciphers were already correct).

Status

READY

Requires Backporting

Yes
Which branch?

2.7 #3862
2.16 #3861

Migrations

If there is any API change, what's the incentive and logic for it.

NO

Todos

Backported

bensze01 added bug mbed TLS team needs: review needs: backports needs: ci needs: reviewer labels

bensze01 self-assigned this

bensze01 added this to To Do in Mbed TLS Unified Board via automation

bensze01 changed the title ~~Do not set iv size for ECB~~ Do not set iv size for ECB mode ciphers

bensze01 force-pushed the bensze01:ecb_iv_fix branch from 7f3b256 to a2bf2b4

bensze01 added component: TLS and removed component: TLS needs: ci labels

ronald-cron-arm self-requested a review

bensze01 added the component: TLS label

gilles-peskine-arm reviewed

Contributor

gilles-peskine-arm left a comment

The ECB code doesn't use the IV information, so this is unlikely to affect application code. The information is not used in the library (it's only used for CBC to do padding and in some AEAD code) so there's no test data to fix. Code that was calling mbedtls_cipher_set_iv(&ctx, iv, mbedtls_cipher_get_iv_size(&ctx)) for ECB will still work.

It would be good to have tests for this metadata but that's part of a large test gap so I won't request a non-regression test here.

Please write a changelog entry. Other than that looks good to me.

ronald-cron-arm reviewed

Contributor

ronald-cron-arm left a comment

LGTM

ronald-cron-arm added needs: work and removed needs: review needs: reviewer labels

bensze01 dismissed ronald-cron-arm’s stale review via 9d73771

bensze01 force-pushed the bensze01:ecb_iv_fix branch from a2bf2b4 to 9d73771

Mbed TLS Unified Board automation moved this from To Do to In Progress

bensze01 requested review from gilles-peskine-arm and ronald-cron-arm

bensze01 removed the needs: work label

ronald-cron-arm reviewed

ChangeLog.d/ecb_iv_fix.txt Outdated

  
      @@ -0,0 +1,3 @@
    
        Bugfix

           * Correct the default iv size for mbed_cipher_info_t structures using

             MBEDTLS_MODE_ECB to 0, since ecb mode ciphers don't use ivs.

ronald-cron-arm Nov 6, 2020
Contributor

Nitpick: ECB instead of `ecb` and while at it probably that "IV" is better than "iv".

bensze01 Nov 6, 2020
Author Contributor

Done.


          Do not set IV size for ECB mode ciphers

a8e40dd

ECB mode ciphers do not use IVs

Signed-off-by: Bence Szépkúti <[email protected]>

bensze01 force-pushed the bensze01:ecb_iv_fix branch from 9d73771 to a8e40dd

bensze01 requested a review from ronald-cron-arm

ronald-cron-arm approved these changes

Contributor

ronald-cron-arm left a comment

LGTM

Contributor

gilles-peskine-arm commented Nov 6, 2020

pr-merge passed but the status reporting to GitHub failed.

gilles-peskine-arm approved these changes

Mbed TLS Unified Board automation moved this from In Progress to Has Approval

This was referenced Nov 6, 2020

Backport 2.16: Do not set IV size for ECB mode ciphers #3861

Merged

Backport 2.7: Do not set IV size for ECB mode ciphers #3862

Merged

bensze01 added ready for merge and removed needs: backports labels

gilles-peskine-arm merged commit e3994d7 into ARMmbed:development

8 of 10 checks passed

8 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built

Details

PR-3836-merge Result analysis In progress

Details

DCO DCO

Details

PR-3836-head Pre Test Checks OK

Details

PR-3836-head Result analysis OK

Details

PR-3836-head TLS Testing All tests passed

Details

PR-3836-merge Pre Test Checks OK

Details

PR-3836-merge TLS Testing All tests passed

Details

continuous-integration/jenkins/pr-head This commit looks good

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

Mbed TLS Unified Board automation moved this from Has Approval to Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.