The Wayback Machine - https://web.archive.org/web/20201207151301/https://github.com/mapbox/mapbox-gl-native/issues/11108
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilecount binding integration #11108

Open
tobrun opened this issue Feb 2, 2018 · 5 comments
Open

Tilecount binding integration #11108

tobrun opened this issue Feb 2, 2018 · 5 comments

Comments

@tobrun
Copy link
Member

@tobrun tobrun commented Feb 2, 2018

With #9906, @asheemmamoowala implemented a seperate util::tileCount() method for computing the number of tiles that need to be downloaded for offline packs.

Sidenote from #9460 (comment):

Note that the tile count depends on the minzoom and maxzoom specified in the source's TileJSON, so calculating it depends on having downloaded at least that resource.

@1ec5
Copy link
Member

@1ec5 1ec5 commented Mar 22, 2018

#11504 tracks the iOS/macOS equivalent to the feature requested here.

@tmpsantos
Copy link
Member

@tmpsantos tmpsantos commented Oct 19, 2018

tilecount is used in this context for download size estimation.

@LukasPaczos
Copy link
Member

@LukasPaczos LukasPaczos commented Oct 29, 2018

Capturing from the #4258, it looks like estimating based only on the tile count would be the least precise of the estimates, we'd have to base it on an average tile size, which might be far off from the actual size of downloaded resources, is that right? If so, is a raw tilecount the way to serve the use-case?

@asheemmamoowala
Copy link
Contributor

@asheemmamoowala asheemmamoowala commented Oct 29, 2018

@LukasPaczos the tile count is useful for partially determining if the region's size will go over the Offline Tile limit. The actual tiles added to the offline database for a region depends on how many of them are already available in another region. Computing the list of tiles exclusive to a new offline region would require a separate, more expensive computation.

@LukasPaczos LukasPaczos removed the lift: 1 label Nov 6, 2018
@stale stale bot added the archived label May 5, 2019
@stale
Copy link

@stale stale bot commented May 5, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this May 5, 2019
@stale stale bot removed the archived label May 6, 2019
@chloekraw chloekraw added Core and removed Android labels Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.