Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimplement RemoveShortcut #1290
Merged
implement RemoveShortcut #1290
Conversation
|
Looks good! |
shortcut_test.go
Outdated
| @@ -15,6 +15,22 @@ func TestShortcutHandler_AddShortcut(t *testing.T) { | |||
| assert.Equal(t, 2, len(handle.entry)) | |||
| } | |||
|
|
|||
| func TestShortcutHandler_RemoveShortut(t *testing.T) { | |||
toaster
Sep 8, 2020
Member
Suggested change
func TestShortcutHandler_RemoveShortut(t *testing.T) {
func TestShortcutHandler_RemoveShortcut(t *testing.T) {
Suggested change
| func TestShortcutHandler_RemoveShortut(t *testing.T) { | |
| func TestShortcutHandler_RemoveShortcut(t *testing.T) { |
shortcut_test.go
Outdated
| handle := &ShortcutHandler{} | ||
| handle.AddShortcut(&ShortcutCopy{}, func(shortcut Shortcut) {}) | ||
| handle.AddShortcut(&ShortcutPaste{}, func(shortcut Shortcut) {}) | ||
|
|
||
| assert.Equal(t, 2, len(handle.entry)) | ||
|
|
||
| handle.RemoveShortcut(&ShortcutCopy{}) | ||
|
|
||
| assert.Equal(t, 1, len(handle.entry)) | ||
|
|
||
| handle.RemoveShortcut(&ShortcutPaste{}) | ||
|
|
||
| assert.Equal(t, 0, len(handle.entry)) |
Comment on lines
19
to
31
toaster
Sep 8, 2020
Member
Suggested change
handle := &ShortcutHandler{}
handle.AddShortcut(&ShortcutCopy{}, func(shortcut Shortcut) {})
handle.AddShortcut(&ShortcutPaste{}, func(shortcut Shortcut) {})
assert.Equal(t, 2, len(handle.entry))
handle.RemoveShortcut(&ShortcutCopy{})
assert.Equal(t, 1, len(handle.entry))
handle.RemoveShortcut(&ShortcutPaste{})
assert.Equal(t, 0, len(handle.entry))
handler := &ShortcutHandler{}
handler.AddShortcut(&ShortcutCopy{}, func(shortcut Shortcut) {})
handler.AddShortcut(&ShortcutPaste{}, func(shortcut Shortcut) {})
assert.Equal(t, 2, len(handler.entry))
handler.RemoveShortcut(&ShortcutCopy{})
assert.Equal(t, 1, len(handler.entry))
handler.RemoveShortcut(&ShortcutPaste{})
assert.Equal(t, 0, len(handler.entry))
Suggested change
| handle := &ShortcutHandler{} | |
| handle.AddShortcut(&ShortcutCopy{}, func(shortcut Shortcut) {}) | |
| handle.AddShortcut(&ShortcutPaste{}, func(shortcut Shortcut) {}) | |
| assert.Equal(t, 2, len(handle.entry)) | |
| handle.RemoveShortcut(&ShortcutCopy{}) | |
| assert.Equal(t, 1, len(handle.entry)) | |
| handle.RemoveShortcut(&ShortcutPaste{}) | |
| assert.Equal(t, 0, len(handle.entry)) | |
| handler := &ShortcutHandler{} | |
| handler.AddShortcut(&ShortcutCopy{}, func(shortcut Shortcut) {}) | |
| handler.AddShortcut(&ShortcutPaste{}, func(shortcut Shortcut) {}) | |
| assert.Equal(t, 2, len(handler.entry)) | |
| handler.RemoveShortcut(&ShortcutCopy{}) | |
| assert.Equal(t, 1, len(handler.entry)) | |
| handler.RemoveShortcut(&ShortcutPaste{}) | |
| assert.Equal(t, 0, len(handler.entry)) |
kevingentile
Sep 8, 2020
Author
Contributor
Note, this change is inconsistent with the existing tests in this file
Note, this change is inconsistent with the existing tests in this file
|
Looks good - @toaster can you please confirm if you are happy with the changes |
|
Looks llike the file was changed a lot so some merge conflicts to resolve @kevingentile sorry |
kevingentile
force-pushed the
kevingentile:remove-shortcut
branch
from
9d7788d
to
a5ff42a
kevingentile
force-pushed the
kevingentile:remove-shortcut
branch
from
a5ff42a
to
b0dedcb
|
Static check failing: /home/runner/work/fyne/fyne/shortcut.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description:
Addresses #1278 for shortcut cleanup
Checklist:
Where applicable: