Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Tailwind preset improvements #862
Comments
I'm guessing by "aliases" you mean adding keys to match based on the current keys to prevent breaking changes? |
Yes exactly! let fontSizes = [...]
fontSizes.lg = 2;
let colors = {...};
colors.purple.500 = colors.purple[5]; In that way, you can choose whether you want to use the underlying system tailwind-style (if you're used to their classnames already) or theme-ui style. |
iirc this was just copied over from the other presets (maybe too be coherent?) |
Should be copied from Tailwind, no? |
Edited my message to clarify Yeah, even though this will be a breaking change, this should be done IMO if this is called the "tailwind preset". Jackson might have some opinions on that. |
I strongly think if it's the Tailwind preset it should use the Tailwind system, not half of the Tailwind system and half random values |
If you want to use a lesser spacing scale, that's fine, but yeah it'd be a breaking change and would potentially make the preset less interoperable with other Theme UI presets |
That's a good point |
Uhh nice, thanks for the mention @mxstbr Next to the issue with the colors, I found out as well that values from Also extending min/max sizes with our custom size variables, but thats personal opinion I guess. Note: My issues are probably within |
In order to make the Tailwind preset more approachable for people that already know Tailwind, we should:
lg
=2
)purple.5
===purple.500