I think that it would be nice for the load balancer to set the host header. We don't use the host header much, so this hasn't been a priority for us. That said, I think it would be really good to do as not everyone is so lax with their HTTP.

I'm sorry I don't have better news for you.

@bryce-anderson
Thank you for your kind reply!

I opened this issue because HTTP/1.1 obligates us to set Host header.
Some middleware, e.g. consul, don't accept the request without Host header and return the 400 BadRequest.

I hope this issue will be resolved in the future, thanks!

Is this not resolved yet? It bit me :(

@vigneshwaranr, I'm sorry to say that we haven't invested in this yet.

@vigneshwaranr would you like to take a stab at this? It might look something like having an option on the Http client that lets you set the host header for requests if it hasn't been set yet.

We can't use Finagle with AWS ALB unless this is fixed. It's a blocker for us. I can probably devote time to fixing this if anyone would be kind enough to point me in the right direction.

@justinpermar try making a Stack module beneath the load balancer. The load balancer injects the address of the remote peer into Stack.Params, so you should be able to use that.

Also, can you elaborate on why you need this ability? Host headers typically refer to the virtual host, and since we typically load balance over remote peers in a cluster that are all the same, they typically share a virtual host.

@mosesn As noted above, HTTP 1.1 spec requires valid Host header. We're making requests with Finagle to AWS ALB, which rejects the requests with 400: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-troubleshooting.html#http-400-issues.

@justinpermar my question is why you need a different host header per endpoint. Is there a single virtual host which represents everything in your remote cluster? For example, if I talk to google.com, I always set my host header as google.com, even though I might choose a specific IP address to talk to.

I'm wondering if maybe you could set the host header yourself, instead of relying on finagle doing it on your behalf after load balancing.

@mosesn Ah I see what you're asking now. Yes, setting the host header is a workaround for our use case (I'm currently in the process of testing our application with a special-case configuration that does just that). But it's very hacky, since I have to set a host header manually for each request instead of letting Finagle just "do the right thing". As an aside, curl and other http tools set the host header, so it seems like a good idea that Finagle follows suit.

@justinpermar yeah, the tricky thing is that curl and other HTTP tools can infer the host header because they assume you pass a URL. Finagle doesn't assume that, and indeed many users just resolve IP addresses from zookeeper (or similar). We could potentially add an HTTP-specific configuration method as a helper, something like Http.client.withHostHeader("twitter.com") but then the downside would be that if you dump the request before you pass it to the client, it doesn't actually reflect what it will look like when it's sent.

The RequestBuilder API is intended to address this problem, but it's pretty limited in what it checks, since HTTP is such a complicated protocol.

Is there anything wrong with setting the host header via a filter?

case class WithHostHeader(host: String) extends SimpleFilter[Request, Response] {
  override def apply(request: Request, service: Service[Request, Response]): Future[Response] = {
    request.host = host
    service(request)
  }
}

WithHostHeader("localhost").andThen(Http.newService("localhost"))

@dreverri no, that will work fine. This issue is specifically for when you want a different host header for different remote peers in the same loadbalancer.

Hi

It would be nice to have this feature.

@mosesn are you able to give more detail on this please?

try making a Stack module beneath the load balancer. The load balancer injects the address of the remote peer into Stack.Params, so you should be able to use that.

I would like to give it a try

Thanks