Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
API should not accept modification of local_path for nom-manual projects #7665
Assignees
Comments
ryanpetrello
added
state:has_unmerged_pr
state:needs_test
and removed
state:needs_devel
labels
thedoubl3j
added a commit
to thedoubl3j/awx
that referenced
this issue
Oct 27, 2020
… in a SCM project and test case
softwarefactory-project-zuul bot
added a commit
that referenced
this issue
Oct 27, 2020
related #7665 added 400 if user attempts an edit to local_path in a SCM project Reviewed-by: https://github.com/apps/softwarefactory-project-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ISSUE TYPE
SUMMARY
The API will accept a PATCH to edit
local_pathfor a git project, but the change will not take effect.Some version of a 400 error would be preferable to this. This is a valid field to edit in the case of manual projects, so there's no valid justification that it's "not a field".
ENVIRONMENT
STEPS TO REPRODUCE
PATCH
/api/v2/projects/6/{ "description": "asdf", "local_path": "_6__demo_project_edited" }EXPECTED RESULTS
One of:
ACTUAL RESULTS
No error
description changes to "asdf"
the
local_pathremains at prior value of "_6__demo_project"