Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Bug: Devtools' update-notifier usage is overly eager #20061
Comments
|
Looks like this was added some time ago in facebook/react-devtools#695 Would you be interested in contributing a PR that uses the |
|
Hey @NickHeiner ! If you have not started, can I give it a try? Seems pretty straight-forward to add the check. Should we customise the message too (something more generic) ? |
|
I don't think anyone has started on this, so please feel free @recurx. |
|
Thanks @bvaughn . |
|
I think the message is fine. Any reason to change it? |
|
Was just wondering about this sentence in the issue -
|
|
I see. We could add update the wording to include |
|
Like I said, I don't think we need to cover all use case |
|
Yes, @recurx, thanks for pointing out my concern about the message being incorrect. I agree that it's impractical to cover all use cases. And, frankly, for my users, it's not great to have a message that says something like "use yarn or use npm", because devs in my repo must use yarn. The ideal solution from my end (and one that should be very easy to implement) is simply to provide an option to suppress showing this update notifier entirely. That option could default to |
Practically speaking, developers in your repo will encounter many libraries that say |
|
I know that many packages use update-notifier, but in this case, we actually don't have many other command line tools printing out install instruction messages. (Off the top of my head, I can't think of a single one.) And, while I agree that in general, JS devs should have the wherewithal to translate Is this entire issue critical? No, probably not in any scenario. As a monorepo infrastructure maintainers, would I prefer to have more control over which messages are shown to my dev community? Absolutely. |
While it's not the outcome you're advocating for, I think it is still relevant to what prompted you to open the issue– since it reduces how frequently you'll see this (non-actionable) prompt. If you would like to submit a PR that adds the ability to permanently opt out of this, you'd be welcome to. It doesn't look like that's something the library we're using provides support for though– and I suspect it's an uncommon enough want that not many people would be interested in doing the leg work but maybe I'm wrong. |
|
Yes, I agree that reducing the frequency reduces the impact of the issue. Perhaps I will submit that PR! Thanks for the invitation. |
|
Hi, is this issue still opened? |
|
Hi, if possible I would like to tackle this issue. Please let me know if it is still open. Thanks! |
|
I will hold off to give the other commenters a chance to work on this. |
|
Hi, is this issue still open for contribution, I am new to the open-source community and looking forward to opportunities to contribute. Thanks in advance! |




When I run the devtools, I get the
update-notifiermessage:I appreciate the goal of this message. However, the suggested command to run is incorrect for my repo. We use yarn, not npm. And we use a monorepo. This is confusing for devs who are new to the repo.
Would it be possible to suppress the
update-notifiermessage? The team that manages usage of react-devtools in our tool chain is happy to stay on top of updates themselves.