The Wayback Machine - https://web.archive.org/web/20190518111454/https://github.com/Unitech/pm2/pull/3955
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package command for BSD tar #3955

Open
wants to merge 1 commit into
base: development
from

Conversation

Projects
None yet
4 participants
@poppinlp
Copy link
Contributor

commented Oct 11, 2018

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #3951
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls
@CLAassistant

This comment has been minimized.

Copy link

commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@poppinlp poppinlp changed the title Issue3951 fix package command for BSD tar Oct 11, 2018

@poppinlp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2018

I checkout this branch from master branch and send PR to development branch. Seems that makes those other commits there. Dose this matter?

@Unitech

This comment has been minimized.

Copy link
Owner

commented Oct 11, 2018

Thanks for this contribution, I will try it out on a mac and eill merge this PR. No it does not matter that some other commits got introduced in it, that’s my fault not having merged the hot fix in dev)

@poppinlp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2018

OK. Thanks.

Actually there's an error in test case code when i run npm test on my mac:
image

Here's where error happen:
image

@poppinlp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2018

Sorry i just find out the commit message rules. And the commit in this PR dose not follow that. T_T
Maybe we could check the commit message by git hook? If you'd like, i'll send a PR for that by using huksy and commitlint.

@devinivy

This comment has been minimized.

Copy link

commented Oct 23, 2018

I'm interested in this patch well—let me know if I can be of any use! @poppinlp were you able to fix the test issue on OSX? I imagine that the commit messages may be able to be fixed by squashing the commits when this PR is merged.

@poppinlp

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

@devinivy OK. I will try to fix the test issue recently if i have time (busy work T_T).

@Unitech Unitech force-pushed the Unitech:development branch 2 times, most recently from 7641d49 to 495c77f Dec 18, 2018

@Unitech Unitech force-pushed the Unitech:development branch 3 times, most recently from ca13ded to 741144e Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.