Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upfix package command for BSD tar #3955
Conversation
This comment has been minimized.
This comment has been minimized.
CLAassistant
commented
Oct 11, 2018
•
poppinlp
changed the title
Issue3951
fix package command for BSD tar
Oct 11, 2018
This comment has been minimized.
This comment has been minimized.
I checkout this branch from master branch and send PR to development branch. Seems that makes those other commits there. Dose this matter? |
This comment has been minimized.
This comment has been minimized.
Thanks for this contribution, I will try it out on a mac and eill merge this PR. No it does not matter that some other commits got introduced in it, that’s my fault not having merged the hot fix in dev) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sorry i just find out the commit message rules. And the commit in this PR dose not follow that. T_T |
This comment has been minimized.
This comment has been minimized.
devinivy
commented
Oct 23, 2018
I'm interested in this patch well—let me know if I can be of any use! @poppinlp were you able to fix the test issue on OSX? I imagine that the commit messages may be able to be fixed by squashing the commits when this PR is merged. |
This comment has been minimized.
This comment has been minimized.
@devinivy OK. I will try to fix the test issue recently if i have time (busy work T_T). |
poppinlp commentedOct 11, 2018