The Wayback Machine - https://web.archive.org/web/20201202055637/https://github.com/mattn/go-sqlite3/pull/877
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vfs for Open #877

Merged
merged 1 commit into from Nov 16, 2020
Merged

Support vfs for Open #877

merged 1 commit into from Nov 16, 2020

Conversation

@mattn
Copy link
Owner

@mattn mattn commented Nov 13, 2020

Closes #876

Closes #876
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 13, 2020

Codecov Report

Merging #877 (ea43798) into master (92f580b) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
- Coverage   47.26%   46.92%   -0.34%     
==========================================
  Files          12       11       -1     
  Lines        1917     1447     -470     
==========================================
- Hits          906      679     -227     
+ Misses        876      635     -241     
+ Partials      135      133       -2     
Impacted Files Coverage Δ
sqlite3.go 53.38% <100.00%> (+1.20%) ⬆️
sqlite3_load_extension.go 59.37% <0.00%> (-3.67%) ⬇️
backup.go 83.33% <0.00%> (-1.29%) ⬇️
callback.go 58.16% <0.00%> (-0.81%) ⬇️
error.go 81.81% <0.00%> (-0.54%) ⬇️
convert.go 0.00% <0.00%> (ø)
sqlite3_go18.go 88.23% <0.00%> (ø)
sqlite3_type.go 0.00% <0.00%> (ø)
sqlite3_context.go 0.00% <0.00%> (ø)
sqlite3_func_crypt.go 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f580b...ea43798. Read the comment docs.

@guenhter
Copy link

@guenhter guenhter commented Nov 13, 2020

Thx. Tested it. Works like a charm

@mattn mattn merged commit 1fbedab into master Nov 16, 2020
25 of 30 checks passed
25 of 30 checks passed
Test (ubuntu-latest, 1.11.13) Test (ubuntu-latest, 1.11.13)
Details
Test (ubuntu-latest, 1.11.13) Test (ubuntu-latest, 1.11.13)
Details
Test (ubuntu-latest, 1.12.17) Test (ubuntu-latest, 1.12.17)
Details
Test (ubuntu-latest, 1.12.17) Test (ubuntu-latest, 1.12.17)
Details
Test (ubuntu-latest, 1.13.15) Test (ubuntu-latest, 1.13.15)
Details
Test (ubuntu-latest, 1.13.15) Test (ubuntu-latest, 1.13.15)
Details
Test (ubuntu-latest, 1.14.7) Test (ubuntu-latest, 1.14.7)
Details
Test (ubuntu-latest, 1.14.7) Test (ubuntu-latest, 1.14.7)
Details
Test (ubuntu-latest, 1.15) Test (ubuntu-latest, 1.15)
Details
Test (ubuntu-latest, 1.15) Test (ubuntu-latest, 1.15)
Details
Test (macos-latest, 1.11.13) Test (macos-latest, 1.11.13)
Details
Test (macos-latest, 1.11.13) Test (macos-latest, 1.11.13)
Details
Test (macos-latest, 1.12.17) Test (macos-latest, 1.12.17)
Details
Test (macos-latest, 1.12.17) Test (macos-latest, 1.12.17)
Details
Test (macos-latest, 1.13.15) Test (macos-latest, 1.13.15)
Details
Test (macos-latest, 1.13.15) Test (macos-latest, 1.13.15)
Details
Test (macos-latest, 1.14.7) Test (macos-latest, 1.14.7)
Details
Test (macos-latest, 1.14.7) Test (macos-latest, 1.14.7)
Details
Test (macos-latest, 1.15) Test (macos-latest, 1.15)
Details
Test (macos-latest, 1.15) Test (macos-latest, 1.15)
Details
Test for Windows (1.11.13) Test for Windows (1.11.13)
Details
Test for Windows (1.11.13) Test for Windows (1.11.13)
Details
Test for Windows (1.12.17) Test for Windows (1.12.17)
Details
Test for Windows (1.12.17) Test for Windows (1.12.17)
Details
Test for Windows (1.13.15) Test for Windows (1.13.15)
Details
Test for Windows (1.13.15) Test for Windows (1.13.15)
Details
Test for Windows (1.14.7) Test for Windows (1.14.7)
Details
Test for Windows (1.14.7) Test for Windows (1.14.7)
Details
Test for Windows (1.15) Test for Windows (1.15)
Details
Test for Windows (1.15) Test for Windows (1.15)
Details
@mattn mattn deleted the vfs branch Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.