The Wayback Machine - https://web.archive.org/web/20201203191233/https://github.com/ant-design/ant-design/issues/25078
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuleType "type" doesn't include "array" #25078

Open
gwuah opened this issue Jun 18, 2020 · 4 comments
Open

RuleType "type" doesn't include "array" #25078

gwuah opened this issue Jun 18, 2020 · 4 comments

Comments

@gwuah
Copy link

@gwuah gwuah commented Jun 18, 2020

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Project Too Large to isolate

What is expected?

Setting rule of type "array" for tag select component should work successfully. (Typescript project)

What is actually happening?

Setting property rule with value "array" for tag select components fails because it's not declared in the RuleType type.

Environment Info
antd 4.3.4
React 16.13.1
System MacOS Mojave 10.14.6
Browser Chrome

Possible values of rule as defined by async-validator includes the "array" prop as expected.
Screen Shot 2020-06-18 at 4 30 25 AM

But in rc-field-form/lib/interface.d.ts, RuleType doesn't include "array"
Screen Shot 2020-06-18 at 4 30 09 AM

@afc163 afc163 added the help wanted label Jun 18, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 18, 2020

Hello @gwuah. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @gwuah, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

@gwuah
Copy link
Author

@gwuah gwuah commented Jun 18, 2020

@afc163 Hey so I was just wanted to be sure, this isn't an issue from antd right?
The pull request has to go against https://github.com/react-component/field-form/blob/master/src/interface.ts rather.

@afc163
Copy link
Member

@afc163 afc163 commented Jun 18, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.