Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated default shaders for OpenGL 3.2 core profile #5960
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
crykn commentedMar 20, 2020
•
edited
Mac OS only supports the OpenGL 3.2 core profile for OpenGL 3. As core profiles are not backward compatible, this leads to compilation issues with the default shaders in libGDX. This PR adds updated versions of all default shaders and only applies them when using OpenGL 3 on Mac OS.
Furthermore a gwt-compatible
PlatformUtilsclass was added to determine whether the current system is a mac. The need for a class like this was already indicated elsewhere, as the availableUIUtilsis a Scene2D class.Progress in the past: The shader compilation problem in the OpenGL 3.2. core profile is nothing new and was, for example, discussed in this context. At least for
SpriteBatch, work on an updated default shader was already begun. However, those changes where never merged nor did they cover all default shaders in libgdx.To test these changes: Just create a new libGDX project or open an already existing one on Mac OS. Then set the useGL30-flag to true (this only works with the lwjgl3 background, as libgdx doesn't allow you to use a core profile with lwjgl2). You may have to set
ShaderProgram.preprendVertex/FragmentCodeto#version 150 \n, as this is the only supported shader version for Mac and OpenGL 3. Then use any of your favourite classes that has a default shader (SpriteBatch,ShapeRenderer, etc.). Without the PR this will fail, as the shader cannot be compiled - with this PR everything works fine.