Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
QJsonArray's iterator doesn't return references, so acknowledge this in the code #6038
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
src/net/bootstrapnodeupdater.cpp:186 says:
which implies that we're taking a ref-to-const-QJsonValue, while actually we're making a temporary copy of a QJsonValueRef and then binding a const-ref to that. Instead, write:
to make it explicit that the copy is happening (it is, regardless of the
&above), but also that it's of a lightweight "Ref" object.