The Wayback Machine - https://web.archive.org/web/20201129110615/https://github.com/atom/atom/issues/20077
Skip to content

/ atom

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file ends with colon open but content isnt read #20077

Open
ghost opened this issue Oct 28, 2019 · 6 comments · May be fixed by #21124
Open

file ends with colon open but content isnt read #20077

ghost opened this issue Oct 28, 2019 · 6 comments · May be fixed by #21124
Labels
d ⬆️ good first issue hacktoberfest i ⬇️ linux triaged v ⬇️

Comments

@ghost
Copy link

@ghost ghost commented Oct 28, 2019 •
edited by rsese

Edit by @rsese to add more specific repro steps

  1. echo "123" > a:
  2. Application: Open File (Ctrl+O on Linux)
  3. Select the file from step 1

Expect the a: file to open, actual behavior is an empty a titled tab is open.

Seems : is legal though maybe not ideal for a filename on Linux? : is illegal for a filename on Windows and I'm not sure about macOS behavior if it's specifically an illegal character but the behavior was the same on macOS 10.14.6 (except the file open dialog showed a/ in the open dialog).

Prerequisites

Description

Steps to Reproduce

  1. create file a:
  2. write to it
  3. open with atom

Expected behavior:

open the content

Actual behavior:

not open the content

Reproduces how often:

∞

Versions

Atom : 1.37.0
Electron: 2.0.18
Chrome : 61.0.3163.100
Node : 8.9.3
debian

Additional Information

im using atom 1.37 x64 version on linux.
i tried to open a file that ends with ':' and it opened but content of file didn't load. it loaded it empty.
@rsese
Copy link
Member

@rsese rsese commented Nov 11, 2019

Thanks for reaching out!

im using atom 1.37 x64 version on linux.

I was unable to reproduce with Atom 1.41.0 on Ubuntu 19.04. Can you update to 1.41.0 and let us know if you still see the same issue?

I'm also assuming I understand this part of your report correctly:

Actual behavior:

not open the content

Just to clarify, you mean the file opens but it's empty? Or does the file not open at all?
@ghost
Copy link
Author

@ghost ghost commented Nov 11, 2019

Thanks for reaching out!

im using atom 1.37 x64 version on linux.

I was unable to reproduce with Atom 1.41.0 on Ubuntu 19.04. Can you update to 1.41.0 and let us know if you still see the same issue?

I'm also assuming I understand this part of your report correctly:

Actual behavior:

not open the content

Just to clarify, you mean the file opens but it's empty? Or does the file not open at all?

hello,

i thought theere are no contributors..

i updated to atom 1.41.0.

reproduce:
echo "123" > a:
in atom : Ctrl + O (file -> open file)
open a: file
it opened a window but it's empty.

what works: directory -> open file, filenme like ":"

i was trying to fix the issue by compiling the atom source code like https://gist.github.com/anriseth/8385fe663db51ce4a218868bdb1cba7b but it failed with some v8 file not sure what....
@rsese
Copy link
Member

@rsese rsese commented Nov 16, 2019

in atom : Ctrl + O (file -> open file)

Oh interesting - with this extra detail I can reproduce 👍 The original step wasn't specific and I opened the file from the tree view where it opens ok. But opening the file through the file dialog reproduces.

I see that the tab filename is actually a and not a: when trying to open a: through the file open dialog.
@ghost
Copy link
Author

@ghost ghost commented Nov 18, 2019

in atom : Ctrl + O (file -> open file)

Oh interesting - with this extra detail I can reproduce +1 The original step wasn't specific and I opened the file from the tree view where it opens ok. But opening the file through the file dialog reproduces.

I see that the tab filename is actually a and not a: when trying to open a: through the file open dialog.

exactly.. that what i was saying .....
meanwhile, if no contributor mind you say how to compile atom so i can trace it? I tried to follow some gist but it didn't work some error with V9/V8 Chrome JS Engine...
@ghost
Copy link
Author

@ghost ghost commented Dec 3, 2019

@lee-dohm what are those labels mean?
@lee-dohm
Copy link
Member

@lee-dohm lee-dohm commented Dec 3, 2019

They’re what we use to prioritize tasks against each other.
@sadick254 sadick254 linked a pull request that will close this issue Jul 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d ⬆️ good first issue hacktoberfest i ⬇️ linux triaged v ⬇️
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Avoid replacing : in filename
3 participants
@rsese @lee-dohm @sadick254
You can’t perform that action at this time.