Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
#2549 introduced the
allow_columns_to_appear_in_same_group_by_clause!
macro that allows you to use more than one column in your group by clause. It opted not to generate a call to this macro for all columns in the schema viadiesel print-schema
due to compile time concerns.I would like to see some experimentation and some concert numbers for the actual compile time impact of this. As I think that's a good first issue, I will writeup some steps for someone willing to work on this:
allow_tables_in_same_query!
here we want to generate a call toallow_columns_to_appear_in_same_group_by_clause!
.All required data are contained in
self.tables
. We need to iterate over all tables and all columns for each table and generate the corresponding macro call there.schema.rs
with the change in 1. appliedschema.rs
without the change in 1. appliedschema.rs
module (but to some other module) may be interesting.