The Wayback Machine - https://web.archive.org/web/20220507131308/https://github.com/kivy/kivy/pull/7231
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard: Add keyboard suggestions and fix input type on android #7231

Merged
merged 4 commits into from Jan 12, 2021
Merged

Keyboard: Add keyboard suggestions and fix input type on android #7231

merged 4 commits into from Jan 12, 2021

Conversation

dwmoffatt
Copy link
Contributor

@dwmoffatt dwmoffatt commented Nov 27, 2020 •
edited by matham

This PR gives kivy the ability to set keyboard input type correctly on android.

Emojis do not work as the default font doesn't support them. It also creates some oddities when using input filtering and emojis are entered.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@welcome
Copy link

@welcome welcome bot commented Nov 27, 2020

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

@gottadiveintopython
Copy link

@gottadiveintopython gottadiveintopython commented Nov 27, 2020

Have you seen #6716 and kivy/python-for-android#2057? I'd recommend you to talk to @Franccisco if you want to work on this kind of feature.

@dwmoffatt
Copy link
Author

@dwmoffatt dwmoffatt commented Nov 27, 2020

I have seen both of those PRs. I commented on one of them and never heard back from @Franccisco .This implementation is his but finished via patching the SDL Activity. I have tried it and the only issue I have with it relates to emojis, which cause some oddities.

I am going to look into a solution for that as well.

@shashi278
Copy link

@shashi278 shashi278 commented Nov 28, 2020

@dwmoffatt But there's a known issue with TYPE_CLASS_TEXT that is, textinput doesn't show text as you type. It only shows when you tap on a suggestion. So just wanted to know if this PR fixes that?

@dwmoffatt
Copy link
Author

@dwmoffatt dwmoffatt commented Nov 28, 2020

@shashi278 I did not notice that when testing it. What you are speaking of seemed to be related to a missing on_textedit which is now part of the textInput class.

@shashi278
Copy link

@shashi278 shashi278 commented Nov 28, 2020 •
edited

@dwmoffatt My bad. Yes it's already there. But you know, that still doesn't work unless you change inputType inside SDLActivity.java. Will that be fixed in this one?

@dwmoffatt
Copy link
Author

@dwmoffatt dwmoffatt commented Nov 28, 2020 •
edited

@shashi278 Not in this PR, as it requires patching SDLActivity. There is a python-for-android PR for that fix. kivy/python-for-android#2361

This PR and that PR together fix the issue with the input type not working on android.

@JuditSN
Copy link

@JuditSN JuditSN commented Dec 23, 2020

Is already merged? @tshirtman

@tshirtman
Copy link

@tshirtman tshirtman commented Dec 23, 2020

Is already merged? @tshirtman

No, neither PR are merged at the moment, as indicated by the green "open" label at the top of the page.

@matham matham mentioned this pull request Dec 30, 2020
Open
@matham matham added the Status: On-hold label Dec 30, 2020
@matham matham mentioned this pull request Jan 8, 2021
Open
@dwmoffatt dwmoffatt mentioned this pull request Jan 9, 2021
Merged
@dwmoffatt
Copy link
Author

@dwmoffatt dwmoffatt commented Jan 11, 2021 •
edited

@tshirtman @matham

the python-for-android pr that is associated with this one is merged. Is there anything needed for this PR?

matham
matham requested changes Jan 11, 2021
View changes
Copy link
Member

@matham matham left a comment

Also, please update request_keyboard in window_pygame.py (even though we don't really support pygame anymore)

kivy/uix/behaviors/focus.py Outdated Show resolved Hide resolved
@matham matham changed the title Fixed input type on android Keyboard: Add keyboard suggestions and fix input type on android Jan 11, 2021
@matham matham added Component: core-providers and removed Status: On-hold labels Jan 11, 2021
@matham matham added this to the 2.1.0 milestone Jan 11, 2021
@matham matham mentioned this pull request Jan 11, 2021
Closed
matham
matham requested changes Jan 12, 2021
View changes
kivy/uix/behaviors/focus.py Show resolved Hide resolved
@matham matham merged commit 554e98f into kivy:master Jan 12, 2021
32 checks passed
@welcome
Copy link

@welcome welcome bot commented Jan 12, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@matham matham mentioned this pull request Jan 19, 2021
Open
@matham matham mentioned this pull request Feb 7, 2021
Closed
hamlet4401 pushed a commit to tytgatlieven/kivy that referenced this issue Jul 3, 2021
@dwmoffatt
Keyboard: Add keyboard suggestions and fix input type on android (kiv…
2bc5b70 
…y#7231)

* Fixed input type on android

* Updated addedversion tag to 2.1.0

* Updated pygame request_keyboard

* fixed PEP8 error
@misl6 misl6 mentioned this pull request Jan 9, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham

Assignees
No one assigned
Labels
Component: core-providers
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dwmoffatt @gottadiveintopython @shashi278 @JuditSN @tshirtman @matham