Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add com.twitter.finagle.zipkin.core.Endpoint.ipv6 #526
Labels
Comments
|
@adriancole @mosesn If no one is working on it, i would like to work on this issue. |
|
please do!
|
|
@mosesn Are you still working on this? If not, I'd like to give it a try |
|
@flostadler it doesn't appear that anyone has been working on this. Please do give it a try. |
|
@kevinoliver All right, I'm on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address.
https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276
It looks like the most pivotal change is updating
com.twitter.finagle.zipkin.core.Endpoint.ipv6cc @sveinnfannar