The Wayback Machine - https://web.archive.org/web/20210923091642/https://github.com/OpenDiablo2/OpenDiablo2/issues/909
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Encoders for all file formats in `d2common/d2fileformats/ #909

Open
gravestench opened this issue Nov 8, 2020 · 1 comment
Open

File Encoders for all file formats in `d2common/d2fileformats/ #909

gravestench opened this issue Nov 8, 2020 · 1 comment

Comments

@gravestench
Copy link
Member

@gravestench gravestench commented Nov 8, 2020

We currently only have file decoders in d2fileformats. Most of the Load functions take a byte slice as an argument, and parse the bytes into a struct for that file type. We need to be able to convert a struct instance back to a byte slice.

@rjnienaber
Copy link

@rjnienaber rjnienaber commented Jun 27, 2021

I did a cursory check and it seems like d2dcc and d2mpq are the only file formats that still require a .Marshal method. Is this required for those formats? If so, I'd like to take a shot at the .dcc one but I don't have an example file that I could commit to the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants