The Wayback Machine - https://web.archive.org/web/20201209183828/https://github.com/topics/wallet
Skip to content
#

wallet

Here are 1,439 public repositories matching this topic...

Jas0n-F
Jas0n-F commented Aug 12, 2020

Bug Report

Problem

In a private group chat that I created, assigned a name and act as an admin, I am unable to successfully change the name.

Expected behavior

[comment]: # Group chat name is able to be changed

Actual behavior

[comment]: # Group chat name is not able to be changed

Notes

For the developer who will be investigating. Is it related to anothe

WalletWasabi
nopara73
nopara73 commented May 19, 2020

GetVerboseBlockInfo uses NBitcoin's SendCommandAsync, which parses the returned JSON with Newtonsoft.

Then our RpcParser parses it again with Newtonsoft.

There're 2 opportunities to improve the performance significantly:

  • Don't parse the JSON twice.
  • Parse the JSON with System.Text.JSON instead.

The performance gain was about 80% when I messed around with it (https://github.

gre
gre commented Apr 19, 2019

Add the ability to go above the year to see longer graphs.

Technical notes:

  • that means asking more dates to countervalues API. Some changes needed in live-common. For a given currency we can infer the afterDay to use by using the older operation
  • if oldest operation of the chart is under 365 days, the graph can fallback on the year mode
  • it might be recommended switching to week
PIVX
gre
gre commented Feb 20, 2019

this is the natural behavior of node-hid but we should backport this behavior to all other transports.

basically it's a failsafe for race conditions.

if you open() a transport, you are responsible to close() it in a finally, if an open() happens during that time it should throw if it concerns the same device (e.g. by path id / by uuid, ... depending on the transport)

Improve this page

Add a description, image, and links to the wallet topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the wallet topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.