Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Tests wanted: run monodis and pedump #9257
Comments
|
Another good step would be to run the tools and ensure the only output is from the tools and not some warning messages from the runtime like we had in https://bugzilla.xamarin.com/show_bug.cgi?id=56608. |
|
@akoeplinger the implementer can follow a similar path to e.g mono-symbolicate's test setup for output validation: https://github.com/mono/mono/blob/88d853487e7b61c8b3d358c3fd9ca7ce4f782eb0/mcs/tools/mono-symbolicate/Makefile |
|
We already test pedump as part of mono runtime tests, see |
Every time we unwittingly change how the mono runtime is supposed to be initialized, we forget to update
main()inmonodisand. They don't have any tests, so we end up shipping binaries that segfault on startup.pedumpTest plan:
monodison some small assembly and check that it exits with exit code 0runpedumpon some small assembly and check that it exits with exit code 0Add that to
run-jenkins.sh