The Wayback Machine - https://web.archive.org/web/20201125014543/https://github.com/xamarin/xamarin-macios/pull/9621
Skip to content

/ xamarin-macios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix inconsistent use of punctuation in argument descriptions #9621

Merged
merged 2 commits into from Sep 15, 2020
Merged

[Bug] Fix inconsistent use of punctuation in argument descriptions #9621

merged 2 commits into from Sep 15, 2020

Conversation

@whitneyschmidt
Copy link
Contributor

@whitneyschmidt whitneyschmidt commented Sep 10, 2020

Fix #8612
@whitneyschmidt
fix inconsistent use of punctuation in argument descriptions
Loading status checks…
4f9eb64
@whitneyschmidt whitneyschmidt added this to the Future milestone Sep 10, 2020
@whitneyschmidt whitneyschmidt requested a review from tj-devel709 Sep 10, 2020
@monojenkins
Copy link
Collaborator

@monojenkins monojenkins commented Sep 11, 2020

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded
@spouliot
spouliot approved these changes Sep 11, 2020
View changes
Copy link
Contributor

@spouliot spouliot left a comment

We could write a unit test for this, like

  • include (if not already) Driver.cs in mtouch-tests project
  • ensure options are initialized (which might require a bit of refactoring)
  • unit test to scan all descriptions and ensure they ends with a ..
@rolfbjarne
rolfbjarne approved these changes Sep 11, 2020
View changes
@dalexsoto
dalexsoto approved these changes Sep 11, 2020
View changes
@mandel-macaque
mandel-macaque approved these changes Sep 11, 2020
View changes
@tj-devel709
tj-devel709 approved these changes Sep 11, 2020
View changes
@whitneyschmidt whitneyschmidt mentioned this pull request Sep 14, 2020
Open
@whitneyschmidt
Merge branch 'main' of github.com:xamarin/xamarin-macios into fix_pun…
Loading status checks…
da42f1c 
…ctuation
@monojenkins
Copy link
Collaborator

@monojenkins monojenkins commented Sep 15, 2020

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded
@whitneyschmidt
Copy link
Contributor Author

@whitneyschmidt whitneyschmidt commented Sep 15, 2020

@monojenkins backport d16-8
@monojenkins
Copy link
Collaborator

@monojenkins monojenkins commented Sep 15, 2020

@whitneyschmidt backporting to d16-8 failed, the patch results in conflicts:

Applying: fix inconsistent use of punctuation in argument descriptions
Using index info to reconstruct a base tree...
M	tools/common/Driver.cs
Falling back to patching base and 3-way merge...
Auto-merging tools/common/Driver.cs
CONFLICT (content): Merge conflict in tools/common/Driver.cs
error: Failed to merge in the changes.
Patch failed at 0001 fix inconsistent use of punctuation in argument descriptions

Please backport manually!
@whitneyschmidt whitneyschmidt merged commit 01254a0 into xamarin:main Sep 15, 2020
2 of 3 checks passed
2 of 3 checks passed
Backport to d16-8 Backport failed.
Details
Build Build success. No test results found.
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto

@rolfbjarne rolfbjarne

@spouliot spouliot

@mandel-macaque mandel-macaque

@tj-devel709 tj-devel709

@chamons chamons

Assignees
No one assigned
Labels
bug not-notes-worthy
Projects
None yet
Milestone
Future
Linked issues

Successfully merging this pull request may close these issues.

[mtouch/mmp] punctuation in argument descriptions should be consistent.
7 participants
@whitneyschmidt @monojenkins @dalexsoto @rolfbjarne @spouliot @mandel-macaque @tj-devel709
You can’t perform that action at this time.