The Wayback Machine - https://web.archive.org/web/20201123172414/https://github.com/haproxy/haproxy/issues/61
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that a subdir match (`-m dir`) matches anywhere down the hierarchy #61

Open
TimWolla opened this issue Mar 11, 2019 · 0 comments
Open

Comments

@TimWolla
Copy link
Member

@TimWolla TimWolla commented Mar 11, 2019

It was reported in https://www.mail-archive.com/[email protected]/msg33009.html (Re: Small question regarding the sub-dir match (i.e. -m dir) with regard to "rooted" patterns) that the documentation regarding the sub-dir match is a bit unclear in that it could be misunderstood to only match directories at the prefix:

On Mon, Mar 11, 2019 at 12:58 PM Tim Düsterhus <snip> wrote:

The documentation only talks about a slash-delimited value, not about
being at the beginning.

Technically yes, it works as documented, except the documentation is
misleading by using the work subdir match right in the beginning...

Moreover the name of the operator is dir which (my guess is that)
most would just mistakenly associate with a file-system, where they
would expect to match a prefix.

I would strongly suggest adding an explicit warning in the
documentation about this pitfall.

Consider amending the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.