The Wayback Machine - https://web.archive.org/web/20201210222820/https://github.com/rubyconfig/config/issues/68
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with secrets.yml #68

Open
smith opened this issue Mar 7, 2014 · 4 comments
Open

Integration with secrets.yml #68

smith opened this issue Mar 7, 2014 · 4 comments

Comments

@smith
Copy link

@smith smith commented Mar 7, 2014

Rails 4.1 introduces a built-in convention for having a secrets.yml with secrets in it: http://edgeguides.rubyonrails.org/4_1_release_notes.html#config-secrets-yml

It would be cool if this gem did some of these things:

  • Aliased Rails.application.secrets to Settings.secrets
  • Shimmed the secrets.yml functionality in for Rails < 4.1
  • Allowed you to have a secrets.local.yml or config/secrets/production.yml that behave the same way as the existing conventions do for non-secrets files

I think this gem is a better overall solution to managing configuration, but if Rails is making this a thing, it would make sense to go along with it and make this gem work nicely with the new stuff.

@pkuczynski pkuczynski added this to the 1.0 milestone Mar 31, 2014
@Darkside73
Copy link

@Darkside73 Darkside73 commented Aug 18, 2014

Will be great

@pkuczynski pkuczynski modified the milestone: 1.0 May 12, 2016
@pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Jun 28, 2019

@rdubya would you like to have a look at this one?

@pkuczynski pkuczynski added this to the 2.0.1 milestone Jun 28, 2019
@rdubya
Copy link
Contributor

@rdubya rdubya commented Jul 1, 2019

Rails 5 gets away from using secrets and now has a credentials file. It would be cool to have similar functionality built into this gem since it provides a much more flexible way of managing environment settings.

@pkuczynski
Copy link
Member

@pkuczynski pkuczynski commented Aug 6, 2019

I think we could add alias Rails.application.secrets to Settings.secrets if anybody is interested in this. However, I would keep the way secrets.yml work meaning with environments groups.

@smith @Darkside73 are you still interested in this?

@pkuczynski pkuczynski modified the milestones: 2.1.0, 2.2.0, 2.2.1, 2.3.0 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.