Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add NAN_MODULE_WORKER_ENABLED macro as a replacement for NAN_MODULE that supports multiple workers #792
Conversation
…hat supports multiple workers Uses the named symbol node_register_module_v## variant of registration that works on node 10.5 with --experimental-workers. May need updating in the future if node requires native modules to explicitly opt in to multiple isolate support.
nan.h
Outdated
| #if NODE_MAJOR_VERSION >= 10 || \ | ||
| NODE_MAJOR_VERSION == 9 && NODE_MINOR_VERSION >= 3 | ||
| #define NAN_CONCAT(a, b) NAN_CONCAT_HELPER(a, b) | ||
| #define NAN_CONCAT_HELPER(a, b) a##b |
kkoopa
Jul 1, 2018
Collaborator
I would prefer these two to be defined regardless of the Node version, since they effectively become public.
I would prefer these two to be defined regardless of the Node version, since they effectively become public.
…ck so that it's consistently declared
|
Thank you. |
yuche
added a commit
to yuche/node-xxhash
that referenced
this pull request
Aug 5, 2020
yuche
added a commit
to yuche/node-xxhash
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Uses the named symbol
node_register_module_v##variant of registration that works to support loading in multiple workers on node 10.5 with--experimental-workers.This may need updating in the future if/when node requires native modules to explicitly opt in to multiple isolate support.