The Wayback Machine - https://web.archive.org/web/20220413234814/https://github.com/expo/expo/pull/16378
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix Android Studio menu names, screenshots #16378

Merged
merged 4 commits into from Apr 12, 2022
Merged

Conversation

Copy link
Contributor

@karlhorky karlhorky commented Feb 19, 2022

Why

The Android Studio UI changed, and the old names of the menu items are outdated now

How

I started the new version of Android Studio and took screenshots

Test Plan

I tested with the new version of Android Studio

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: passed checks label Feb 19, 2022
Copy link
Collaborator

@Simek Simek left a comment

Hello @karlhorky, thank you for the update! 👍

Can you retake the screenshots with transparent background and resize them to 800px in width?

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Feb 20, 2022

Hm, cmd-shift-4 + space (to take the transparent background) doesn't seem to also capture the context menu unfortunately... Or did you have other ideas to take it?

@Simek
Copy link
Collaborator

@Simek Simek commented Feb 20, 2022

Oh, that's might be a bit more effort consuming task then. I would take the window and context menu screenshot separately, then merge them in one of graphical programs. If it is too much to ask, please let me know, so I can update the problematic image soon.

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Feb 21, 2022

Probably won't get around to that soon, so feel free to take over

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Mar 3, 2022

@Simek FWIW I think that having the background in the images both:

  1. Makes the images smaller (transparent images are larger)
  2. Doesn't make too much of a difference with UX, since the background is visible in the images (see the slight variations in background color of the images in screenshots below - it looks almost like they have a color in the background already)

Screen Shot 2022-03-03 at 20 43 22

Screen Shot 2022-03-03 at 20 43 30

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Apr 12, 2022

@Simek did you get a chance to edit these images?

To be clear, I think they also look fine with the background (and the images can also be compressed better without partially transparent background)

@karlhorky karlhorky changed the title Fix menu names Fix Android Studio docs: menu names, screenshots Apr 12, 2022
@karlhorky karlhorky changed the title Fix Android Studio docs: menu names, screenshots [docs] Fix Android Studio menu names, screenshots Apr 12, 2022
@Simek
Copy link
Collaborator

@Simek Simek commented Apr 12, 2022

Sorry, but I have forgot about this issue. 😅

Let's use those images:
Screenshot 2022-04-12 at 13 01 01
Screenshot 2022-04-12 at 12 57 26

@Simek
Copy link
Collaborator

@Simek Simek commented Apr 12, 2022

It would be also nice to mention that the AVD Manager moves to the corner "dot" menu, when user have at least one project already. There is screenshot for that.

Screenshot 2022-04-12 at 13 06 03

@karlhorky Please, let me know if you are still interested in updating this PR. 🙂

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Apr 12, 2022

@Simek sure, so I'll take those images and put them into the docs as they are then, with a small text addition to talk about the top right three dots menu.

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Apr 12, 2022

@Simek done, uploaded the images and added the note about the alternate position

@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Apr 12, 2022

@Simek on an unrelated note, I'm not sure if you maintain the rest of these docs here as well, but I'm creating a new guide as part of our System Setup guide for our coding bootcamp at https://upleveled.io, and I have a simpler version of the rest of the instructions that you may want to use (it avoids installing the latest emulator, which doesn't currently work with Expo).

If you're interested in these changes, watch that repo for my commits in the next hour or so.

Copy link
Collaborator

@Simek Simek left a comment

Thank you ping on this and for the updates! 🙏 LGTM, let's ship it!

@Simek
Copy link
Collaborator

@Simek Simek commented Apr 12, 2022

(it avoids installing the latest emulator, which doesn't currently work with Expo).

@karlhorky Can you elaborate on this a bit more? I'm not aware of such issue.

Also, since it is a bit of topic of this PR, can you create issue or discussion for that, instead of continuing the conversation in there?

If you're interested in these changes, watch that repo for my commits in the next hour or so.

Thanks, I will take a look at this in my free time. 🙂

@Simek Simek merged commit b123c34 into expo:main Apr 12, 2022
2 checks passed
@karlhorky karlhorky deleted the patch-1 branch Apr 12, 2022
@karlhorky
Copy link
Contributor Author

@karlhorky karlhorky commented Apr 12, 2022

Here's the commit 🙌 upleveled/system-setup@da62141

Rendered:

Can you elaborate on this a bit more? I'm not aware of such issue.

Just installed the latest Android Studio using the Standard install like 5 times today on an M1 chip, and every time I tried starting the demo app (expo init --template blank) in an API 32 virtual device (Pixel 3A), it failed with INSTALL_FAILED_INSUFFICIENT_STORAGE, kind of similar to #4186

I tried increasing the storage space to 2000MB, but nothing was helping 🤔 Created a fresh API 30 (Pixel 3A) and no problems.

I'll see if I have time to create an issue over the next weeks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants