The Wayback Machine - https://web.archive.org/web/20220305172722/https://github.com/expo/expo/pull/16430
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Introduce sync-sdk-branch-changelogs #16430

Merged
merged 2 commits into from Mar 4, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Feb 24, 2022

Why

make life easier when syncing changelogs from sdk branches to main

How

  1. get published versions in sdk branch changelogs
  2. get changes from published versions.
  3. back to current branch (main), move changed items from unpublished section to versioned section.

Screen Shot 2022-02-24 at 10 42 09 PM

Test Plan

this commit changes are mostly from this tool.

@Kudo Kudo force-pushed the @kudo/tools/sync-sdk-branch-changelogs branch from 05a1691 to c4c87c2 Feb 24, 2022
@Kudo Kudo changed the title @kudo/tools/sync sdk branch changelogs [tools] Introduce sync-sdk-branch-changelogs Feb 24, 2022
@Kudo Kudo marked this pull request as ready for review Feb 24, 2022
@Kudo Kudo requested a review from tsapeta as a code owner Feb 24, 2022
tsapeta
tsapeta approved these changes Mar 1, 2022
Copy link
Member

@tsapeta tsapeta left a comment

Thanks! I hope this is just a temporary solution and we will start publishing from the main branch finally.

tools/src/Changelogs.ts Outdated Show resolved Hide resolved
tools/src/Changelogs.ts Outdated Show resolved Hide resolved
tools/src/Changelogs.ts Outdated Show resolved Hide resolved
tools/src/Git.ts Outdated Show resolved Hide resolved
tools/src/commands/SyncSdkBranchChangelogs.ts Outdated Show resolved Hide resolved
tools/src/commands/SyncSdkBranchChangelogs.ts Outdated Show resolved Hide resolved
tools/src/commands/SyncSdkBranchChangelogs.ts Outdated Show resolved Hide resolved
tools/src/commands/SyncSdkBranchChangelogs.ts Outdated Show resolved Hide resolved
tsapeta
tsapeta approved these changes Mar 4, 2022
@Kudo
Copy link
Contributor Author

@Kudo Kudo commented Mar 4, 2022

Thanks! I hope this is just a temporary solution and we will start publishing from the main branch finally.

as long as we keep introducing breaking changes from main branches, e.g. upgrading react-native, kotlin version, it's still not feasible to publish hotfixes from main. but i agree and also hope if we can publish from main one day 🤩 thanks for your great review!

@Kudo Kudo merged commit 2be4fa5 into main Mar 4, 2022
5 checks passed
@Kudo Kudo deleted the @kudo/tools/sync-sdk-branch-changelogs branch Mar 4, 2022
@tsapeta
Copy link
Member

@tsapeta tsapeta commented Mar 4, 2022

In terms of Kotlin version, this problem should be fixed by #16213 — it gives expo-modules-core control on the version, so all expo modules will always use the same version as specified in the core (or overriden by the user)

@Kudo
Copy link
Contributor Author

@Kudo Kudo commented Mar 4, 2022

that's a great improvement. so ideally if we can put every version related stuffs in expo-modules-core and we could probably publish other package's hotfixes from main. i'll try to align this strategy in the future. thanks for the sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants