The Wayback Machine - https://web.archive.org/web/20220325051547/https://github.com/kubernetes/kubernetes/issues/108806
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: kube-proxy internal naming #108806

Open
thockin opened this issue Mar 18, 2022 · 3 comments
Open

Cleanup: kube-proxy internal naming #108806

thockin opened this issue Mar 18, 2022 · 3 comments
Assignees
Labels
good first issue help wanted kind/cleanup sig/network triage/accepted

Comments

@thockin
Copy link
Member

@thockin thockin commented Mar 18, 2022

We have sort of a mish-mash of "service" and "servicePort" and similar.

We should think about changing ALL of the places that actually relate to a service-port (a specific port of a service, not the whole service) and rename them to some new term that means "service port". E.g. "svcpt" or "spt" or "sport".

See 8fffae3 in pkg/proxy/iptables/proxier.go and friends. e.g. info.serviceNameString -> info.svcptNameString ?

@thockin thockin added sig/network kind/cleanup help wanted good first issue triage/accepted labels Mar 18, 2022
@gkarthiks
Copy link
Member

@gkarthiks gkarthiks commented Mar 18, 2022

I would like to take this one.

/assign

@gkarthiks
Copy link
Member

@gkarthiks gkarthiks commented Mar 18, 2022

/assign

@thockin
Copy link
Member Author

@thockin thockin commented Mar 18, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted kind/cleanup sig/network triage/accepted
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants