The Wayback Machine - https://web.archive.org/web/20220405120246/https://github.com/jesseduffield/lazygit/issues/1858
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation prompt type to custom commands #1858

Open
jesseduffield opened this issue Apr 5, 2022 · 0 comments
Open

Add confirmation prompt type to custom commands #1858

jesseduffield opened this issue Apr 5, 2022 · 0 comments
Labels
enhancement good first issue

Comments

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Apr 5, 2022

Is your feature request related to a problem? Please describe.
When creating a custom command by following docs/Custom_Command_Keybindings.md there's no way to have a confirmation popup appear saying e.g. 'Are you sure you want to delete all files?'.

Describe the solution you'd like
We should add a 'confirm' prompt type alongside 'input' and 'menu' in pkg/gui/services/custom_commands/handler_creator.go's call function. That can basically copy what we're doing in inputPrompt but using self.c.Confirm.

We should also update the docs at docs/Custom_Command_Keybindings.md to reflect this new type.

Describe alternatives you've considered
Right now the only alternative is to use a 'menu' prompt with a 'yes' and 'cancel' option.

@jesseduffield jesseduffield added enhancement good first issue labels Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
Projects
None yet
Development

No branches or pull requests

1 participant