The Wayback Machine - https://web.archive.org/web/20220415072004/https://github.com/ethereum/go-ethereum/issues/21783
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informational metrics to prometheus endpoint #21783

Open
ulope opened this issue Nov 3, 2020 · 9 comments
Open

Add informational metrics to prometheus endpoint #21783

ulope opened this issue Nov 3, 2020 · 9 comments

Comments

@ulope
Copy link
Member

@ulope ulope commented Nov 3, 2020

System information

Geth version: 1.9.23
OS & Version: OSX

Feature request

Please add informational metrics to the prometheus endpoint:

  • Chain / network info
  • Geth version

For example:

# TYPE chain_info gauge
chain_info{chain_id="5", network_name="goerli"} 1
# TYPE geth_info gauge
geth_info{version="1.9.23-stable", arch="amd64", os="darwin", commit="deadbeef", protocol_versions="63,64,65"} 1
@karalabe
Copy link
Member

@karalabe karalabe commented Jun 17, 2021

We'd need to investigate a bit how to expose metadata in Prometheus and InfluxDB. I'm all for surfacing these infos, just have no idea yet what the standard way is. If you have any docs you could point us to, that would be grand.

@no-response
Copy link

@no-response no-response bot commented Jul 24, 2021

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have more relevant information or answers to our questions so that we can investigate further.

@no-response no-response bot closed this Jul 24, 2021
@ulope
Copy link
Member Author

@ulope ulope commented Oct 5, 2021

@karalabe Sorry I missed this.

Here's a (pretty old but still accurate) post on the Robust Perception blog

As well as a sample of some of the exporters / tools I've used in the past that include such a metric:

My example above follows this pattern.

@Ab-hishek
Copy link

@Ab-hishek Ab-hishek commented Oct 12, 2021

I would like to work on this issue if this is still required.

@muddlebee
Copy link

@muddlebee muddlebee commented Nov 4, 2021

@karalabe @holiman @MariusVanDerWijden can this be closed ?

MONITORING GETH WITH INFLUXDB AND GRAFANA : https://ethereum.org/en/developers/tutorials/monitoring-geth-with-influxdb-and-grafana/ has been already added.

@muddlebee
Copy link

@muddlebee muddlebee commented Nov 4, 2021

@ulope FYI

@holiman
Copy link
Contributor

@holiman holiman commented Nov 4, 2021

Cannot be closed, no. The issue requests meta-information to be exposed via influx/prometheus, like

# TYPE chain_info gauge
chain_info{chain_id="5", network_name="goerli"} 1
# TYPE geth_info gauge
geth_info{version="1.9.23-stable", arch="amd64", os="darwin", commit="deadbeef", protocol_versions="63,64,65"} 1

Not fixed

@muddlebee
Copy link

@muddlebee muddlebee commented Nov 4, 2021

@holiman this looks interesting. Can I work on this? I am participating in Ethereum "Core Developer" Apprenticeship Program . I might add this as well in my deliverable tasks.

If this sounds good. Can you assign this task to me please?

@holiman
Copy link
Contributor

@holiman holiman commented Nov 4, 2021

Sure, just go ahead.
(no need to assign the ticket though)

@ethereum ethereum deleted a comment from Johny2022 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@ulope @ligi @karalabe @holiman @muddlebee @Ab-hishek and others