The Wayback Machine - https://web.archive.org/web/20220411200537/https://github.com/RustScan/RustScan/issues/291
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write CI that checks for specific outputs in the terminal #291

Open
bee-san opened this issue Oct 18, 2020 · 4 comments
Open

Write CI that checks for specific outputs in the terminal #291

bee-san opened this issue Oct 18, 2020 · 4 comments
Labels
feature_request good first issue hacktoberfest

Comments

@bee-san
Copy link
Member

@bee-san bee-san commented Oct 18, 2020

RustScan has an accessible mode, rustscan --accessible which should promise not to have any weird ASCII text in it.

Write CI that runs RustScan with --accessible a few times, with different flags / options and check the terminal output to see if it contains one of these:

  1. [!]
  2. [~]
  3. [>]
  4. | {}

If any of these characters appear in any of the tests, fail the CI. Else, pass the CI.

This is a hacktoberfest issue if you want it 💖 and we're available in Discord or over GitHub to talk 😄
@issue-label-bot
Copy link

@issue-label-bot issue-label-bot bot commented Oct 18, 2020

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@emhagman
Copy link

@emhagman emhagman commented Sep 29, 2021

Is this still available? I wouldn't mind adding it but I realize this might be stale.

@facklambda
Copy link

@facklambda facklambda commented Nov 1, 2021

Would this be better to make as a test that would fail if one of these outputs is found, thus causing the cargo test invocation in the CI action to fail?

@facklambda
Copy link

@facklambda facklambda commented Nov 1, 2021

I'm going to try my hand at writing a test.

@facklambda facklambda mentioned this issue Nov 1, 2021
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature_request good first issue hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emhagman @facklambda @bee-san