[CALCITE-5288] '(a > 1 and a < 3) or (a > 2 and a < 4)' can't be simplified #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-plekhanov
force-pushed
the
calcite-5288
branch
from
a63ba8f to
6d21739
Compare
…simplified to 'SEARCH(a, Sarg[(5..20)])'
alex-plekhanov
force-pushed
the
calcite-5288
branch
from
6d21739 to
ad88f63
Compare
chunweilei
reviewed
Sep 20, 2022
| // yelds "a >= 1 and a <= 4" | ||
| checkSimplifyFilter( | ||
| or(and(ge(aRef, literal(1)), le(aRef, literal(3))), | ||
| and(ge(aRef, literal(2)), le(aRef, literal(4)))), |
There was a problem hiding this comment.
Could you add a test like "(a >= 1 and a <= 3) or (a >= 0 and a <= 2) -> a>=0 and a<=3 "?
|
I'll merge this PR if there is no objections appear in 24 hours. |
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 11, 2022
…simplified to 'SEARCH(a, Sarg[(5..20)])' This closes apache#2912
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
…simplified to 'SEARCH(a, Sarg[(5..20)])' This closes apache#2912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.