[CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 #1218
Conversation
| @@ -58,7 +58,7 @@ | |||
|
|
|||
| private static final Pattern SESSION_KEY = | |||
| Pattern.compile( | |||
| "<response>\\s*<sessionKey>([0-9a-f]+)</sessionKey>\\s*</response>"); | |||
| "<sessionKey>(.+)<\\/sessionKey>"); | |||
There was a problem hiding this comment.
Not familiar with Splunk's session yet, however as the implementation of Regex sign + in Java is based on longest matching, I am not sure if it's safe enough to use .+ here. Is ([0-9a-f]+) not able to match the content in this case?
There was a problem hiding this comment.
The session key from Splunk contains numbers, a-z in both lower and upper cases, also there are special characters such as ^ and _. So ([0-9a-f]+) could not match connections from the latest version of Splunk. Is ([0-9a-zA-Z^_]+) acceptable in case of safety?
There was a problem hiding this comment.
Yes, please use that one. Thanks for your explanation. :)
There was a problem hiding this comment.
No problem, I will close this pull request first.
There was a problem hiding this comment.
If you meant to change the PR, you can update your own source branch https://github.com/LastSmile732/calcite/tree/CALCITE-3067 then the PR should be able to sync the changes automatically. This way you don't have to close and file a new one.
|
Also, please add and verify the email address used in your commit on GitHub. See the https://help.github.com/en/articles/verifying-your-email-address. |
Fix the regular expression for parsing session keys from Splunk 7.2+